Mesh_3 - fix protecting balls placement #9218
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e_index not p_index, that may be a corner index with dimension 0
lrineau
approved these changes
Jan 5, 2026
Member
lrineau
left a comment
lrineau
left a comment
There was a problem hiding this comment.
Looks good to me. It seems to fix a real bug.
Member
|
Successfully tested in CGAL-6.2-Ic-79 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Here,
pcorresponds to a point on a feature, with dimension 1.We must use
curve_indexand notp_index, which may be a corner index forpcorresponding to a vertex within_dimension=0.The risk is to compare a
Corner_indexand aCurve_indexwhich have the same types (intby default) and same values though they correspond to corner of indexiand curve of indexiRelease Management