Add override specifier to Cartesian kernel transformation representations #9320
+117
−117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the override keyword to all virtual function overrides in the
derived transformation representation classes:
3D: Aff_transformation_repC3, Translation_repC3, Scaling_repC3
2D: Aff_transformation_repC2, Translation_repC2, Scaling_repC2,
Rotation_repC2, Reflection_repC2
This follows C++ Core Guideline C.128: 'Virtual functions should
specify exactly one of virtual, override, or final.' The redundant
virtual keyword is removed in favor of override, which provides
compile-time safety against signature mismatches.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
It adds the
overridespecifier to all overridden virtual functions and removes the redundantvirtualkeyword in the following classes:Aff_transformation_repC3,Translation_repC3,Scaling_repC3Aff_transformation_repC2,Translation_repC2,Scaling_repC2,Rotation_repC2,Reflection_repC2These changes ensure adherence to C++ Core Guideline C.128 ("Virtual functions should specify exactly one of virtual, override, or final"). This improves code safety by enforcing compile-time checks against accidental signature mismatches.
Release Management
Kernel_23