follow up PR #9274 "Mesh_3 - speedup protecting balls placement" by lrineau · Pull Request #9366 · CGAL/cgal

lrineau · 2026-03-10T09:11:13Z

Summary of Changes

a few leftovers after PR #9274

TODO

See issue #9367.

Release Management

Affected package(s): Mesh_3, STL_Extension, Surface_mesh, TDS_3 (so far)
Issue(s) solved (if any): fix Mesh_3 - speedup protecting balls placement #9274
License and copyright ownership: N/A

off-topic, but an improvement nonetheless

sloriot · 2026-03-10T13:24:38Z

Why does this PR modify Surface_mesh?

lrineau · 2026-03-10T14:05:32Z

Why does this PR modify Surface_mesh?

Because I sneaked aafe3b5 (virtual → override) in this PR.

sloriot · 2026-03-11T06:30:26Z

Why does this PR modify Surface_mesh?

Because I sneaked aafe3b5 (virtual → override) in this PR.

Let me rephrase: Why are you doing this modification in this PR? A dedicated PR with some explanations would be better. Properties are not even used AFAIK in Mesh_3.

`CGAL::sqrt` for native types (`float`, `double`, `int`...) does the same but through the abstraction of `Algebraic_foundations`.

... and make it explicit that `weight_modifier` is the square of another constant.

- fix headers, - comments, - factorize the display of a range of ids into a function

I do not understand why the code is trying to recompute that value equal to 1. Let's remove that complexity for now. I hope it was not a way to take floating point inexactness into account.

move that block of code to where it is actually used

- rename `prims` to `curve_primitives` - add a scope block, that is the "creation" of `curve_primitives` (should be an [Immediately invoked function expression] - rearrange block of comments, to distinguish the parts of the code that should be in different sub-functions [Immediately invoked function expression]: https://en.wikipedia.org/wiki/Immediately_invoked_function_expression

Mesh_3/include/CGAL/Sizing_field_with_aabb_tree.h

https://cgal.geometryfactory.com/CGAL/Manual_doxygen_test/CGAL-6.2-Ic-137/logs2/Mesh_3.log

TDS_3/include/CGAL/Triangulation_data_structure_3.h

STL_Extension/include/CGAL/tags.h

Co-authored-by: Sebastien Loriot <sloriot.ml@gmail.com>

sloriot · 2026-03-30T08:52:28Z

Successfully tested in CGAL-6.2-Ic-141

lrineau

@sloriot

Here are the three points that currently block the integration of this draft pull-request. Those three points need to be discussed.

Once those three points are addressed, the pull-request could be merged. As least it fixes the issue #9369, and it will fix issue #9371 if we agree to document the is_parallel static data member of Sequential_tag and Parallel_tag.

STL_Extension/include/CGAL/tags.h

TDS_3/include/CGAL/Triangulation_data_structure_3.h

STL_Extension/doc/STL_Extension/CGAL/tags.h

github-actions · 2026-03-30T09:59:28Z

This pull-request was previously marked with the label Tested, but has been modified with new commits. That label has been removed.

sloriot · 2026-04-01T15:59:57Z

Successfully tested in CGAL-6.2-Ic-144

sloriot · 2026-04-01T16:00:21Z

@sloriot

Here are the three points that currently block the integration of this draft pull-request. Those three points need to be discussed.

Once those three points are addressed, the pull-request could be merged. As least it fixes the issue #9369, and it will fix issue #9371 if we agree to document the is_parallel static data member of Sequential_tag and Parallel_tag.

All fixed, right?

lrineau added 4 commits March 10, 2026 10:06

remove leftovers

983d903

use override instead of virtual

aafe3b5

off-topic, but an improvement nonetheless

add TODOs for this PR

34d57b6

the doc of CGAL::Boolean_tag is syntactically wrong

e791f74

lrineau added Pkg::Mesh_3 Cleaning Pkg::Surface_mesh Pkg::TDS_3 Pkg::STL_Extension labels Mar 10, 2026

lrineau added this to the 6.2-beta milestone Mar 10, 2026

lrineau mentioned this pull request Mar 10, 2026

follow up PR #9274 "Mesh_3 - speedup protecting balls placement" #9367

Open

lrineau linked an issue Mar 10, 2026 that may be closed by this pull request

follow up PR #9274 "Mesh_3 - speedup protecting balls placement" #9367

Open

lrineau added 3 commits March 10, 2026 17:07

missing headers (for IWYU/clangd)

a1dfc28

call sqrt by ADL (no CGAL_NTS or CGAL::)

6d39b88

only comments

bdbe158

lrineau added 9 commits March 13, 2026 10:07

it is simpler to call directly std::sqrt for native types

48d8708

`CGAL::sqrt` for native types (`float`, `double`, `int`...) does the same but through the abstraction of `Algebraic_foundations`.

fix warnings from IWYU/clangd

f79b566

do not use CGAL global functions (but functors of the kernel)

76aefa2

turn constants into inline constexpr

24b89cd

... and make it explicit that `weight_modifier` is the square of another constant.

cosmetic changes (hopefully)

4737b70

- fix headers, - comments, - factorize the display of a range of ids into a function

0.9 / sqrt(CGAL::Mesh_3::internal::weight_modifier) is equal to 1

ed4b81c

I do not understand why the code is trying to recompute that value equal to 1. Let's remove that complexity for now. I hope it was not a way to take floating point inexactness into account.

move the block "compute distance to the other curves"

c3fccc1

move that block of code to where it is actually used

add a variable to "document" what is closest_prim_id.second

e6b252f

sloriot added the Under Testing label Mar 23, 2026

afabri reviewed Mar 24, 2026

View reviewed changes

Mesh_3/include/CGAL/Sizing_field_with_aabb_tree.h Outdated Show resolved Hide resolved

Apply suggestion from @afabri

226858d

https://cgal.geometryfactory.com/CGAL/Manual_doxygen_test/CGAL-6.2-Ic-137/logs2/Mesh_3.log

sloriot reviewed Mar 24, 2026

View reviewed changes

TDS_3/include/CGAL/Triangulation_data_structure_3.h Outdated Show resolved Hide resolved

sloriot reviewed Mar 24, 2026

View reviewed changes

STL_Extension/include/CGAL/tags.h Outdated Show resolved Hide resolved

Apply suggestions from code review

d906b99

Co-authored-by: Sebastien Loriot <sloriot.ml@gmail.com>

sloriot added Tested and removed Under Testing labels Mar 30, 2026

lrineau commented Mar 30, 2026

View reviewed changes

STL_Extension/include/CGAL/tags.h Show resolved Hide resolved

TDS_3/include/CGAL/Triangulation_data_structure_3.h Show resolved Hide resolved

STL_Extension/doc/STL_Extension/CGAL/tags.h Outdated Show resolved Hide resolved

after discussion with @sloriot, prefer B over b

4ae9277

github-actions bot removed the Tested label Mar 30, 2026

document Concurrent)_tag::is_parallel

ebd5f0a

sloriot added the Under Testing label Mar 30, 2026

document TDS_3::vertices

80e32bb

sloriot mentioned this pull request Mar 31, 2026

Add value member to Sequential_tag and Parallel_tag #9406

Closed

sloriot added Tested and removed Under Testing labels Apr 1, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

follow up PR #9274 "Mesh_3 - speedup protecting balls placement"#9366

follow up PR #9274 "Mesh_3 - speedup protecting balls placement"#9366
lrineau wants to merge 21 commits intoCGAL:mainfrom
lrineau:CGAL-follow_up_PR_9274__Mesh_3-speedup_balls_wip-jtournois__-lrineau

lrineau commented Mar 10, 2026 •

edited

Loading

Uh oh!

sloriot commented Mar 10, 2026 •

edited

Loading

Uh oh!

lrineau commented Mar 10, 2026

Uh oh!

sloriot commented Mar 11, 2026 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sloriot commented Mar 30, 2026

Uh oh!

lrineau left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Mar 30, 2026

Uh oh!

sloriot commented Apr 1, 2026

Uh oh!

sloriot commented Apr 1, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

lrineau commented Mar 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary of Changes

TODO

Release Management

Uh oh!

sloriot commented Mar 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lrineau commented Mar 10, 2026

Uh oh!

sloriot commented Mar 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sloriot commented Mar 30, 2026

Uh oh!

lrineau left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Mar 30, 2026

Uh oh!

sloriot commented Apr 1, 2026

Uh oh!

sloriot commented Apr 1, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

lrineau commented Mar 10, 2026 •

edited

Loading

sloriot commented Mar 10, 2026 •

edited

Loading

sloriot commented Mar 11, 2026 •

edited

Loading