Refactors the implementation and the test#2
Merged
CGaaaaaa merged 3 commits intoCGaaaaaa:mainfrom Dec 4, 2025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors and modernizes both the implementation and the test suite of the reactive library, focusing on code style improvements and enhanced test assertions. The main changes include replacing manual increment/decrement operations with the
+=and-=operators, updating test assertions to use more idiomatic assertion functions, and improving output formatting for example and test code.Operator Implementation Improvements
count = count + 1) with compound assignment operators (count += 1,count -= 1) in all observable operators for consistency and clarity. (src/reactivex.mbt)Test Suite Modernization
assert_eq,assert_true,assert_false) instead of manual checks andpanic(), improving readability and reliability of tests. (src/test.mbt)Output Formatting Enhancements
value.to_string()in all example and test output, ensuring correct and consistent output formatting. (src/examples.mbt,src/test.mbt)These changes collectively improve code readability, maintainability, and test reliability across the codebase.