[CHERIoT]: Add cheriot_sealed attribute
#158
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xdoardo
force-pushed
the
cheriot-static-sealed-value-attr
branch
2 times, most recently
from
6f58ce9 to
c46c12f
Compare
resistor
reviewed
May 29, 2025
xdoardo
force-pushed
the
cheriot-static-sealed-value-attr
branch
from
f0dd9de to
737632e
Compare
resistor
reviewed
May 30, 2025
clang/lib/Sema/SemaDecl.cpp
Outdated
| // directive and has static storage duration. | ||
| if (auto *VD = dyn_cast<VarDecl>(D); | ||
| LangOpts.OpenMP && VD && VD->hasAttr<OMPDeclareTargetDeclAttr>() && | ||
| if (LangOpts.OpenMP && VD && VD->hasAttr<OMPDeclareTargetDeclAttr>() && |
Collaborator
There was a problem hiding this comment.
It's not so much about style, just that it'd be nice not to introduce changes on lines unrelated to CHERIoT for easier merging.
resistor
reviewed
May 30, 2025
llvm/lib/Target/RISCV/RISCV.h
Outdated
| /// perms" encoding. The low 32 bits represent the encoding of the | ||
| /// permissions. | ||
| uint64_t SecondWordValue; | ||
| enum SecondWordKind { |
resistor
approved these changes
May 30, 2025
xdoardo
force-pushed
the
cheriot-static-sealed-value-attr
branch
from
77b7f12 to
bee533d
Compare
resistor
pushed a commit
that referenced
this pull request
May 30, 2025
resistor
pushed a commit
that referenced
this pull request
Aug 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The objective of the PR is that of tackling the second part of #6; in particular,
cheriot_sealedroughly maps to theDECLARE_STATIC_SEALED_VALUEmacro.This attribute is used on types to indicate that variables of this type are intended to be opaque objects, for which the only valid operation is taking their address.