[CHERIoT] Fixes to cheriot_cap_import attribute
#170
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
resistor
reviewed
Jun 6, 2025
xdoardo
force-pushed
the
cheriot
branch
2 times, most recently
from
79343f6 to
ad850de
Compare
resistor
reviewed
Jun 9, 2025
llvm/include/llvm/IR/Attributes.h
Outdated
| (HasWrite ? std::string(WritePermissionSymbol) : "") + | ||
| (HasCap ? std::string(CapPermissionSymbol) : "") + | ||
| (HasMut ? std::string(MutPermissionSymbol) : ""); | ||
| Permissions = (HasRead ? std::string(ReadPermissionSymbol) : "-") + |
Collaborator
There was a problem hiding this comment.
I think this would be a good place to use Twine(...) over std::string(...)
See https://llvm.org/docs/ProgrammersManual.html#the-twine-class and https://llvm.org/docs/ProgrammersManual.html#dss-twine
Collaborator
Author
There was a problem hiding this comment.
8718b52 changes this snippet to use twines.
resistor
approved these changes
Jun 9, 2025
In particular, fix the mangling scheme of permissions ("" -> "-" when
permission not present) and, when checking for volatile qualifiers,
reach to pointee if type is pointer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In particular, this PR fixes the mangling scheme of permissions ("" -> "-" when permission not present) and, when checking for volatile qualifiers, checks the pointee if the type is a pointer.