[CHERIoT]: Fix alignment of cheriot_sealed global variables
#175
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
resistor
approved these changes
Jun 9, 2025
Collaborator
|
I don't think we support OpenMP, but having it in there is also harmless. |
xdoardo
force-pushed
the
cheriot-fix-alignment-sealed-global
branch
from
ced2c18 to
7e53ab5
Compare
Collaborator
Author
Latest commit, 7e53ab5, removes that section of the patch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per title. Before, the emitted alignment was set to
4, but in reality the computation needs to depend on the size of the declared struct. This PR also adds a new bit of tests in the related LLVM-codegen test.