Skip to content

Conversation

@resistor
Copy link
Collaborator

No description provided.

@resistor resistor force-pushed the cap-format branch 2 times, most recently from bdc602c to 3072315 Compare June 26, 2025 17:07
{eFormatInstruction, 'i', "instruction"},
{eFormatVoid, 'v', "void"},
{eFormatUnicode8, 'u', "unicode8"},
{eFormatCheriotCapability, '\0', "cheriot capability"},
Copy link

@rmn30 rmn30 Jun 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does '\0' do here?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you make it 'C' or something?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It provides a single-character name for the format. \0 is the "none" sentinel. Unfortunately 'c' and 'C' are both taken already.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could do something more exotic like '@'?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added 'P' as a single character code for it.

@resistor resistor marked this pull request as ready for review June 27, 2025 07:29
@resistor
Copy link
Collaborator Author

Cleaned up and added unit tests.

@resistor
Copy link
Collaborator Author

resistor commented Jul 2, 2025

Changed formatting to (mostly) match the formatting in RTOS logging.

@resistor resistor merged commit b9c085c into CHERIoT-Platform:cheriot Jul 2, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants