Skip to content

[CHERI CSA] Disable subobject-representability diagnostics on packed structs. #206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 29, 2025
Merged

[CHERI CSA] Disable subobject-representability diagnostics on packed structs. #206

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions clang/lib/StaticAnalyzer/Checkers/CHERI/SubObjectRepresentabilityChecker.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,11 @@ std::unique_ptr<BugReport> checkFieldImpl(const FieldDecl *D, BugReporter &BR,
const BugType &BT) {
QualType T = D->getType();

// If the parent struct is explicitly marked as packed, then don't emit a
// diagnostic, as this layout is likely intentional.
if (D->getParent()->hasAttr<PackedAttr>())
return nullptr;

ASTContext &ASTCtx = BR.getContext();
uint64_t Offset = ASTCtx.getFieldOffset(D) / 8;
if (Offset > 0) {
Expand Down
4 changes: 4 additions & 0 deletions clang/test/Analysis/Checkers/CHERI/subobject-representability-mips64.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,10 @@ struct R1 {
int c[2];
char a[0x1000]; // no warn
} f3good __attribute__((aligned(8)));
struct __attribute__((packed)) {
char c;
char a[0x1000]; // no warn
} f4good;
} s2;
} s1;

Expand Down