Skip to content

[CHERI CSA] Fix a crash in the sub-object representability checker. #207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 31, 2025
Merged

[CHERI CSA] Fix a crash in the sub-object representability checker. #207

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion clang/lib/StaticAnalyzer/Checkers/PointerAlignmentChecker.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -268,7 +268,8 @@ int getTrailingZerosCount(const SVal &V, ProgramStateRef State,

// Sealed capabilities cannot be dereferenced, and any type-punning
// will be dynamically checked during unsealing.
if (V.getType(ASTCtx)->isCHERISealedCapabilityType(ASTCtx))
auto Ty = V.getType(ASTCtx);
if (!Ty.isNull() && Ty->isCHERISealedCapabilityType(ASTCtx))
return -1;

if (V.isConstant()) {
Expand Down
10 changes: 10 additions & 0 deletions clang/test/Analysis/Checkers/CHERI/subobject-representability-crash.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
// RUN: %cheri_purecap_cc1 -analyze %s \
// RUN: -analyzer-checker=core,cheri.SubObjectRepresentability

struct a {
unsigned b;
};
void c(unsigned a::*d) {
d == &a::b;
c(&a::b);
}