Skip to content
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions llvm/include/llvm/IR/Attributes.h
Original file line number Diff line number Diff line change
Expand Up @@ -1482,6 +1482,7 @@ class CHERIoTGlobalCapabilityImportAttr {
auto HasWrite = PermissionsRef.contains(WritePermissionSymbol);
auto HasMut = PermissionsRef.contains(MutPermissionSymbol);
auto HasCap = PermissionsRef.contains(CapPermissionSymbol);
auto _ = PermissionsRef.contains(GlobalPermissionSymbol);

if (!HasRead && !HasWrite) {
FailedSemanticCheckCallback(
Expand Down Expand Up @@ -1573,7 +1574,8 @@ class CHERIoTGlobalCapabilityImportAttr {
static const std::string defaultPermissions() {
return std::string(ReadPermissionSymbol) +
std::string(WritePermissionSymbol) +
std::string(CapPermissionSymbol) + std::string(MutPermissionSymbol);
std::string(CapPermissionSymbol) + std::string(MutPermissionSymbol) +
std::string(GlobalPermissionSymbol);
}

ImportKind ImportKind;
Expand All @@ -1598,7 +1600,10 @@ class CHERIoTGlobalCapabilityImportAttr {
/// The symbol for the mut permission.
static constexpr const char *MutPermissionSymbol = "m";

static constexpr const std::array<char, 4> ValidSymbols = {
/// The symbol for the global permission.
static constexpr const char *GlobalPermissionSymbol = "G";

static constexpr const std::array<char, 5> ValidSymbols = {
ReadPermissionSymbol[0], WritePermissionSymbol[0], CapPermissionSymbol[0],
MutPermissionSymbol[0]};

Expand Down