Add LoadGlobal permission to cheriot_mmio and cheriot_shared_object
#225
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
resistor
approved these changes
Aug 19, 2025
xdoardo
force-pushed
the
mmio-so-allow-load-global
branch
from
de0a91d to
e310c9c
Compare
resistor
force-pushed
the
mmio-so-allow-load-global
branch
from
e310c9c to
d67e26a
Compare
nwf
reviewed
Aug 25, 2025
| /// WritePermission := `WritePermissionSymbol` | "-" | ||
| /// CapPermission := `CapPermissionSymbol` | "-" | ||
| /// WritePermission := `WritePermissionSymbol` | "-" | ||
| /// LoadGlobalPermission := `LoadGlobalPermissionSymbol` | "-" |
Member
There was a problem hiding this comment.
MutPermission seems to have gotten lost here and might want to be renamed to LoadMutPermission or even LoadMutablePermission?
xdoardo
force-pushed
the
mmio-so-allow-load-global
branch
4 times, most recently
from
3ebd26e to
4e0c922
Compare
…`cheriot_shared_object` attributes
xdoardo
force-pushed
the
mmio-so-allow-load-global
branch
from
4e0c922 to
da3f6c0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per title. This change amends the attributes cited in the title so that the same permissions encoding that this change to the RTOS is allowed.