[CHERIoT] Simplify CHERIoT compartment relocation handling in LLD. #275
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to simplify the control flow surrounding the relocation of AUIPCC sequences.
…without paired reloc. This further simplifies control flow around CHERIoT relocation handling, and allows us to collapse the CGPREL_LO_I and CGPREL_LO_S RelExpr's together.
… simplify handling of PCC-relative R_RISCV_CHERIOT_COMPARTMENT_HI relocs.
…tion. This is possible now that isPCCRelative is no longer called in relocate().
Collaborator
Author
|
Manually verified the RTOS test suite passes after these changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This series of patches refactors CHERIoT compartment relocation handling in LLD. The main
change is to resolve which relocations are PCC-relative vs CGP-relative during the rewriting
pre-pass, and to bake that decision using internal relocation numbers. This simplifies logic
downstream, as we no longer have to handle all the possibilities in every case statement.