Skip to content

Comments

Podman support in scripts#363

Draft
mattw-nws wants to merge 3 commits intoCIROH-UA:mainfrom
mattw-nws:guidesh-podman-support
Draft

Podman support in scripts#363
mattw-nws wants to merge 3 commits intoCIROH-UA:mainfrom
mattw-nws:guidesh-podman-support

Conversation

@mattw-nws
Copy link

Enable the use of Podman in place of Docker, primarily to support environments where Docker is not permitted.

Some additional docs are probably needed if there's interest in this, but making it available since I needed to make this modification for our environment.

Additions

  • Adds -p option to substitute podman for docker command in scripts

Removals

  • NA

Updates

  • Adjusts language in some places subbing "container" for "docker" (e.g. "... image")

Testing

Method

Ran through workflows with a Podman system... not all combinations probably tested well. This might be a best-effort-to-unsupported feature.

Screenshots / output snippets

$ ./guide.sh -h
Usage: guide.sh [arg ...]
Options:
  -d [path]: Designates the provided path as the data directory to import into the visualizer.
  -h: Displays usage information, then exits.
  -i [image]: Specifies which Docker image of NGIAB to run.
  -p: Use Podman instead of Docker.
  -r: Retains previous console output when launching the script.
  -t [tag]: Specifies which Docker image tag of NGIAB to run.

→ Cleaning up resources...
  ✓ Cleanup completed.

Checklist

  • PR has an informative and human-readable title
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)

Testing checklist

Target Environment support

  • Windows (wsl)
  • Linux
  • MacOs (apple silicon)

@benlee0423
Copy link
Contributor

@mattw-nws
What you proposed here works in your environment?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Todo

Development

Successfully merging this pull request may close these issues.

2 participants