Docker Compose implementation and Test ARM builds#246
Merged
harshavemula-ua merged 70 commits intomainfrom Sep 5, 2025
Merged
Conversation
…h_docker_X86_arm_version_aware.yaml
harshavemula-ua
changed the title
Collaborator
JordanLaserGit
left a comment
JordanLaserGit
left a comment
There was a problem hiding this comment.
@harshavemula-ua thanks for switching the docker_build.sh to docker compose!
I had one small suggestion on where to write the docker build logs, but I'm happy with these changes.
If you could before merging this PR, delete docker_build.sh and edit the documentation in scripts and docker.
| "runuser -l ec2-user -c 'TAG=latest-arm64 docker compose -f /home/ec2-user/ngen-datastream/docker/docker-compose.yml build forcingprocessor' >> /home/ec2-user/ngen-datastream/docker_build_log.txt 2>&1", | ||
| "runuser -l ec2-user -c 'export DS_TAG=latest-arm64 FP_TAG=latest-arm64 && /home/ec2-user/ngen-datastream/scripts/datastream -s 202006200100 -e 202006200200 -C NWM_RETRO_V3 -d /home/ec2-user/ngen-datastream/data/datastream_test -g https://ngen-datastream.s3.us-east-2.amazonaws.com/palisade.gpkg -R /home/ec2-user/ngen-datastream/configs/ngen/realization_sloth_nom_cfe_pet.json' >> /home/ec2-user/ngen-datastream/docker_build_log.txt 2>&1", | ||
| "runuser -l ec2-user -c '/home/ec2-user/ngen-datastream/research_datastream/terraform/test/docker_loginNpush.sh ${TAG} \"${BUILD_ARGS}\"' >> /home/ec2-user/ngen-datastream/docker_login_log.txt 2>&1", | ||
| "runuser -l ec2-user -c 'aws s3 cp /home/ec2-user/ngen-datastream/docker_login_log.txt s3://ciroh-community-ngen-datastream/docker_login_log.txt'", |
Collaborator
There was a problem hiding this comment.
Let's move these to s3://ciroh-community-ngen-datastream/test/ , just to keep the s3 bucket home page cleaner.
Collaborator
Author
There was a problem hiding this comment.
Sure Jordan, will take care of that. Thanks a lot for reviewing the PR and sharing your comments!
github-project-automation
bot
moved this from In Progress
to Done
in NextGen Research Datastream (NRDS)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated the Build & Test ARM workflow to use the test execution JSON file. This workflow now performs the build activities through the state machine and runs tests(without pushing the images), with all steps logged to the S3 bucket.
During testing, it validates the Docker files for each service. If no changes are detected, the build step is skipped and the latest image is pulled.
Additionally, the docker_builds.sh script has been deprecated since we’ve implemented Docker Compose for image builds. All workflows that previously relied on the shell script have been updated to use Docker Compose instead.
Successful workflow for building and testing Docker containers (ARM): Link
Successful workflow for building, testing, and pushing Docker containers (ARM): Link