Coverage

Author: jmafoster1

tests/testing_tests/test_causal_test_outcome.py

@@ -1,5 +1,5 @@
 import unittest
-from causal_testing.testing.causal_test_outcome import ExactValue, SomeEffect, Positive, Negative
+from causal_testing.testing.causal_test_outcome import ExactValue, SomeEffect, Positive, Negative, NoEffect
 from causal_testing.testing.causal_test_result import CausalTestResult, TestValue
 from causal_testing.testing.estimators import LinearRegressionEstimator
 
@@ -140,6 +140,17 @@ def test_exactValue_pass(self):
         ev = ExactValue(5, 0.1)
         self.assertTrue(ev.apply(ctr))
 
+    def test_exactValue_pass_ci(self):
+        test_value = TestValue(type="ate", value=5.05)
+        ctr = CausalTestResult(
+            estimator=self.estimator,
+            test_value=test_value,
+            confidence_intervals=[4, 6],
+            effect_modifier_configuration=None,
+        )
+        ev = ExactValue(5, 0.1)
+        self.assertTrue(ev.apply(ctr))
+
     def test_exactValue_fail(self):
         test_value = TestValue(type="ate", value=0)
         ctr = CausalTestResult(
@@ -151,18 +162,52 @@ def test_exactValue_fail(self):
         ev = ExactValue(5, 0.1)
         self.assertFalse(ev.apply(ctr))
 
-    def test_someEffect_pass(self):
-        test_value = TestValue(type="ate", value=5.05)
+    def test_someEffect_invalid(self):
+        test_value = TestValue(type="invalid", value=5.05)
         ctr = CausalTestResult(
             estimator=self.estimator,
             test_value=test_value,
             confidence_intervals=[4.8, 6.7],
             effect_modifier_configuration=None,
         )
         ev = SomeEffect()
-        self.assertTrue(ev.apply(ctr))
+        with self.assertRaises(ValueError):
+            ev.apply(ctr)
+
+    def test_someEffect_pass_ate(self):
+        test_value = TestValue(type="ate", value=5.05)
+        ctr = CausalTestResult(
+            estimator=self.estimator,
+            test_value=test_value,
+            confidence_intervals=[4.8, 6.7],
+            effect_modifier_configuration=None,
+        )
+        self.assertTrue(SomeEffect().apply(ctr))
+        self.assertFalse(NoEffect().apply(ctr))
+
+    def test_someEffect_pass_rr(self):
+        test_value = TestValue(type="risk_ratio", value=5.05)
+        ctr = CausalTestResult(
+            estimator=self.estimator,
+            test_value=test_value,
+            confidence_intervals=[4.8, 6.7],
+            effect_modifier_configuration=None,
+        )
+        self.assertTrue(SomeEffect().apply(ctr))
+        self.assertFalse(NoEffect().apply(ctr))
 
     def test_someEffect_fail(self):
+        test_value = TestValue(type="ate", value=0)
+        ctr = CausalTestResult(
+            estimator=self.estimator,
+            test_value=test_value,
+            confidence_intervals=[-0.1, 0.2],
+            effect_modifier_configuration=None,
+        )
+        self.assertFalse(SomeEffect().apply(ctr))
+        self.assertTrue(NoEffect().apply(ctr))
+
+    def test_someEffect_str(self):
         test_value = TestValue(type="ate", value=0)
         ctr = CausalTestResult(
             estimator=self.estimator,
@@ -171,20 +216,29 @@ def test_someEffect_fail(self):
             effect_modifier_configuration=None,
         )
         ev = SomeEffect()
-        self.assertFalse(ev.apply(ctr))
         self.assertEqual(
-            str(ctr),
-            (
-                "Causal Test Result\n==============\n"
-                "Treatment: A\n"
-                "Control value: 0\n"
-                "Treatment value: 1\n"
-                "Outcome: A\n"
-                "Adjustment set: set()\n"
-                "ate: 0\n"
-                "Confidence intervals: [-0.1, 0.2]\n"
-            ),
+            ctr.to_dict(),
+            {
+                "treatment": "A",
+                "control_value": 0,
+                "treatment_value": 1,
+                "outcome": "A",
+                "adjustment_set": set(),
+                "test_value": test_value,
+                "ci_low": -0.1,
+                "ci_high": 0.2,
+            },
+        )
+
+    def test_someEffect_dict(self):
+        test_value = TestValue(type="ate", value=0)
+        ctr = CausalTestResult(
+            estimator=self.estimator,
+            test_value=test_value,
+            confidence_intervals=[-0.1, 0.2],
+            effect_modifier_configuration=None,
         )
+        ev = SomeEffect()
         self.assertEqual(
             ctr.to_dict(),
             {