-
Notifications
You must be signed in to change notification settings - Fork 5
DAFNI Workflow Enhancements #299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦙 MegaLinter status: ✅ SUCCESS
See detailed report in MegaLinter reports |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #299 +/- ##
=======================================
Coverage 93.84% 93.84%
=======================================
Files 27 27
Lines 1593 1593
=======================================
Hits 1495 1495
Misses 98 98 Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
# Conflicts: # dafni/src/main_dafni.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces enhancements to the DAFNI workflow to improve usability and reproducibility. Key changes include:
- Storing variable metadata directly in the dot file and removing the standalone variables.json argument.
- Converting main_dafni.py into a module to facilitate local testing.
- Updating CI/CD workflows and docker-compose configurations for improved build and test processes.
Reviewed Changes
Copilot reviewed 5 out of 10 changed files in this pull request and generated 1 comment.
Show a summary per file
File | Description |
---|---|
dafni/model_definition.yaml | Updated metadata with additional attributes and a modified URL. |
dafni/main_dafni.py | Removed the standalone entry point to favor modular testing. |
dafni/docker-compose.yaml | Adjusted the Dockerfile path and volume mount changes. |
dafni/README.md | Revised directory hierarchy documentation to reflect changes. |
.github/workflows/publish-to-dafni.yaml | Added dependency installation and test execution steps prior to container build. |
Files not reviewed (5)
- dafni/Dockerfile: Language not supported
- dafni/data/inputs/causal_tests.json: Language not supported
- dafni/data/inputs/dag.dot: Language not supported
- dafni/data/inputs/variables.json: Language not supported
- dafni/data/outputs/causal_tests_results.json: Language not supported
Comments suppressed due to low confidence (1)
dafni/model_definition.yaml:2
- The updated URL now includes a percent-encoded space. Please verify that this is the intended URL and that it resolves correctly.
+# https://docs.secure.dafni.rl.ac.uk/docs/How%20to/how-to-write-a-model-definition-file
# Conflicts: # dafni/main_dafni.py
Enhancements to the DAFNI workflow that enables better usability and reproducibility. These include:
variables.json
as an argument. The variables can now be stored as metadata attributes in thedot
file produced by the user.main_dafni.py
into a module, which improves the modularity and testability of the entrypoint in the test suite.