-
Notifications
You must be signed in to change notification settings - Fork 5
Jmafoster1/ignore cycles dafni #307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…rk into jmafoster1/ignore-cycles-dafni
🦙 MegaLinter status: ✅ SUCCESS
See detailed report in MegaLinter reports |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #307 +/- ##
==========================================
- Coverage 97.02% 96.87% -0.16%
==========================================
Files 29 29
Lines 1849 1856 +7
==========================================
+ Hits 1794 1798 +4
- Misses 55 58 +3
Continue to review full report in Codecov by Sentry.
|
Rather annoyingly, the "diff" lines that aren't covered were there before and also not covered (due to it being there to handle an error that's quite hard to elicit), but it's picked it up because I've touched the surrounding code |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jmafoster1 I don't understand why the tests fail locally but run remotely. Is this happening for you?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏼
Some changes to facilitate the DAFNI case study