Skip to content

Conversation

jmafoster1
Copy link
Contributor

Some changes to facilitate the DAFNI case study

Copy link

github-actions bot commented Feb 17, 2025

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ PYTHON black 36 0 0.98s
✅ PYTHON pylint 36 0 6.17s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by OX Security

Copy link

codecov bot commented Feb 17, 2025

Codecov Report

Attention: Patch coverage is 82.35294% with 3 lines in your changes missing coverage. Please review.

Project coverage is 96.87%. Comparing base (88fef70) to head (3a6e2df).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
causal_testing/json_front/json_class.py 72.72% 3 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #307      +/-   ##
==========================================
- Coverage   97.02%   96.87%   -0.16%     
==========================================
  Files          29       29              
  Lines        1849     1856       +7     
==========================================
+ Hits         1794     1798       +4     
- Misses         55       58       +3     
Files with missing lines Coverage Δ
...esting/estimation/abstract_regression_estimator.py 97.95% <ø> (ø)
...esting/estimation/logistic_regression_estimator.py 100.00% <100.00%> (ø)
causal_testing/testing/causal_test_outcome.py 95.38% <100.00%> (ø)
causal_testing/json_front/json_class.py 96.60% <72.72%> (-1.41%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a20954c...3a6e2df. Read the comment docs.

@jmafoster1 jmafoster1 marked this pull request as ready for review February 17, 2025 12:54
@jmafoster1 jmafoster1 requested a review from f-allian February 17, 2025 12:54
@jmafoster1
Copy link
Contributor Author

Rather annoyingly, the "diff" lines that aren't covered were there before and also not covered (due to it being there to handle an error that's quite hard to elicit), but it's picked it up because I've touched the surrounding code

@jmafoster1 jmafoster1 self-assigned this Feb 17, 2025
Copy link
Contributor

@f-allian f-allian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jmafoster1 I don't understand why the tests fail locally but run remotely. Is this happening for you?

Copy link
Contributor

@f-allian f-allian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

@jmafoster1 jmafoster1 merged commit 08ab5aa into main Feb 17, 2025
20 of 22 checks passed
@jmafoster1 jmafoster1 deleted the jmafoster1/ignore-cycles-dafni branch February 17, 2025 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants