Skip to content

Enforce NetworkX 3.4 #328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 6, 2025
Merged

Enforce NetworkX 3.4 #328

merged 5 commits into from
Jun 6, 2025

Conversation

f-allian
Copy link
Contributor

@f-allian f-allian commented Jun 2, 2025

Quick fix to #327

@f-allian f-allian self-assigned this Jun 2, 2025
@f-allian f-allian added the bug Something isn't working label Jun 2, 2025
@f-allian f-allian changed the title Enforce NetworkX 3.4 for now Enforce NetworkX 3.4 Jun 2, 2025
Copy link

github-actions bot commented Jun 2, 2025

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ PYTHON black 31 0 0.96s
✅ PYTHON pylint 31 0 6.06s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by OX Security

Copy link

codecov bot commented Jun 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.69%. Comparing base (fcab481) to head (a940927).
Report is 7 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #328   +/-   ##
=======================================
  Coverage   95.69%   95.69%           
=======================================
  Files          27       27           
  Lines        1602     1603    +1     
=======================================
+ Hits         1533     1534    +1     
  Misses         69       69           
Files with missing lines Coverage Δ
causal_testing/testing/causal_test_case.py 100.00% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7da3aef...a940927. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@f-allian f-allian marked this pull request as ready for review June 2, 2025 14:22
@f-allian f-allian requested a review from jmafoster1 June 2, 2025 14:22
@f-allian f-allian requested a review from jmafoster1 June 3, 2025 15:40
Copy link
Contributor

@jmafoster1 jmafoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I modified the assertions a bit on the tests so that the test case is actually run. I realised that the formula parameter wasn't actually a valid estimate parameter for estimate_ate, so wanted to test the parameters were actually getting used properly.

@f-allian f-allian merged commit e7b8577 into main Jun 6, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants