-
Notifications
You must be signed in to change notification settings - Fork 5
Enforce NetworkX 3.4 #328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enforce NetworkX 3.4 #328
Conversation
🦙 MegaLinter status: ✅ SUCCESS
See detailed report in MegaLinter reports |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #328 +/- ##
=======================================
Coverage 95.69% 95.69%
=======================================
Files 27 27
Lines 1602 1603 +1
=======================================
+ Hits 1533 1534 +1
Misses 69 69
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I modified the assertions a bit on the tests so that the test case is actually run. I realised that the formula
parameter wasn't actually a valid estimate parameter for estimate_ate
, so wanted to test the parameters were actually getting used properly.
Quick fix to #327