Skip to content

Validation to check that outcome and treatment aren't the same #336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 11, 2025

Conversation

jmafoster1
Copy link
Contributor

Closes #114. Added validation in BaseTestCase to check that treatment and outcome are not the same.

Copy link

github-actions bot commented Jul 9, 2025

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ PYTHON black 32 0 1.02s
✅ PYTHON pylint 32 0 7.14s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by OX Security

Copy link

codecov bot commented Jul 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.75%. Comparing base (87f07ec) to head (f2392dd).
Report is 6 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #336   +/-   ##
=======================================
  Coverage   95.75%   95.75%           
=======================================
  Files          27       27           
  Lines        1627     1627           
=======================================
  Hits         1558     1558           
  Misses         69       69           
Files with missing lines Coverage Δ
causal_testing/testing/base_test_case.py 100.00% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac8005f...f2392dd. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jmafoster1 jmafoster1 marked this pull request as ready for review July 9, 2025 08:55
@jmafoster1 jmafoster1 requested a review from f-allian July 9, 2025 08:55
@f-allian f-allian added the enhancement New feature or request label Jul 10, 2025
@f-allian f-allian merged commit b162d8f into main Jul 11, 2025
13 checks passed
@jmafoster1 jmafoster1 deleted the jmafoster1/114-validate-treatment-outcome branch July 11, 2025 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JSON Frontend, add validation to check that outcome and treatment aren't the same
2 participants