-
Notifications
You must be signed in to change notification settings - Fork 5
EffectEstimate dataclass #353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EffectEstimate dataclass #353
Conversation
🦙 MegaLinter status: ✅ SUCCESS
See detailed report in MegaLinter reports |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #353 +/- ##
==========================================
+ Coverage 95.67% 96.28% +0.61%
==========================================
Files 27 28 +1
Lines 1618 1590 -28
==========================================
- Hits 1548 1531 -17
+ Misses 70 59 -11
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jmafoster1 Good idea moving this all into a data class. Looks good to me 👍🏼
Closes #340.
TestValue
class toEffectEstimate
and moved it intoestimation
This is much cleaner than the old solution as estimation methods now return one tidy object that's always of the same type.