Skip to content

Strip Unused Dependencies #354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Aug 11, 2025
Merged

Strip Unused Dependencies #354

merged 7 commits into from
Aug 11, 2025

Conversation

f-allian
Copy link
Contributor

  • PR to remove unused dependencies, including lhsmdu and fitter.

    • Removed the import and usage of lhsmdu in causal_testing/specification/variable.py, including the sample method that used Latin Hypercube Sampling. Both dependencies are also removed from pyproject.toml.
    • Removed the flaky test related to the sampling method in tests/specification_tests/test_variable.py.
  • It also updates the default behaviour for test generation to not skip tests.

    • Changed the default value of the skip parameter in the to_json_stub methods of ShouldCause and ShouldNotCause to False, and updated the docstrings accordingly.
    • Added a warning message in generate_causal_tests to inform users that the skip parameter is now hard-coded to False for better integration, and to encourage careful review of generated tests.

@f-allian f-allian requested a review from jmafoster1 August 11, 2025 10:22
@f-allian f-allian self-assigned this Aug 11, 2025
@f-allian f-allian added the enhancement New feature or request label Aug 11, 2025
Copy link

github-actions bot commented Aug 11, 2025

🦙 MegaLinter status: ⚠️ WARNING

Descriptor Linter Files Fixed Errors Elapsed time
⚠️ PYTHON black 33 1 1.05s
✅ PYTHON pylint 33 0 6.17s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by OX Security

Copy link

codecov bot commented Aug 11, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.27%. Comparing base (6346755) to head (aa74852).
⚠️ Report is 9 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #354      +/-   ##
==========================================
- Coverage   96.28%   96.27%   -0.01%     
==========================================
  Files          28       28              
  Lines        1590     1586       -4     
==========================================
- Hits         1531     1527       -4     
  Misses         59       59              
Files with missing lines Coverage Δ
causal_testing/specification/variable.py 100.00% <ø> (ø)
causal_testing/testing/metamorphic_relation.py 100.00% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d3dd4ab...aa74852. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@f-allian f-allian merged commit e7371aa into main Aug 11, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants