pull request to add option for disabling attachments when sending files via clampmail#61
pull request to add option for disabling attachments when sending files via clampmail#61moodleismylms wants to merge 7 commits intoCLAMP-IT:mainfrom
Conversation
add settings to admin fulltree for disabling attachment field system wide in file email_form.php
…n that remove file input field
|
@moodleismylms I'm curious about your use case. This module was forked from Quickmail for the express purpose of supporting emailed attachments. |
Dear @mackensen , Thank you very much for your reply! As I am new to software development via git/github I was wondering whether I shall open a new pull request as I have seen the check you ran showed some line indentation errors? I was wondering whether you could give me some advice on that. Kind regards |
|
@moodleismylms you should push additional commits on your existing request and the checks will re-run. You don't need to open a new request. |
|
@mackensen Thank you very much! I have pushed the additional commits to the main branch on moodleismylms/clampmail. Thank you very much for your support! |
|
Dear @mackensen, Apparently I have overlooked one line indentation error although one of the test runs displayed the file without errors. This should be fixed now. Kind regards |
Dear all,
I added the option to disable the file upload in the e-mail create form via the admin setting and was wondering whether you could add it to your main branch. In the following you will find a short description of what I changed/added in each file:
Kind regards
Simon