Skip to content

pull request to add option for disabling attachments when sending files via clampmail#61

Open
moodleismylms wants to merge 7 commits intoCLAMP-IT:mainfrom
moodleismylms:main
Open

pull request to add option for disabling attachments when sending files via clampmail#61
moodleismylms wants to merge 7 commits intoCLAMP-IT:mainfrom
moodleismylms:main

Conversation

@moodleismylms
Copy link

Dear all,

I added the option to disable the file upload in the e-mail create form via the admin setting and was wondering whether you could add it to your main branch. In the following you will find a short description of what I changed/added in each file:

  • admin settings added in settings.php
  • updated language file for admin settings in block_clampmail.php
  • if statement inserted to show or not show file upload possibility in email_form.php

Kind regards
Simon

add settings to admin fulltree for disabling attachment field system wide in file email_form.php
@mackensen
Copy link
Member

@moodleismylms I'm curious about your use case. This module was forked from Quickmail for the express purpose of supporting emailed attachments.

@moodleismylms
Copy link
Author

@moodleismylms I'm curious about your use case. This module was forked from Quickmail for the express purpose of supporting emailed attachments.

Dear @mackensen ,

Thank you very much for your reply!
My use case is that some of our moodle users try to use quickmail/clampmail for all their material to be sent to students instead of using a moodle course for their material. With time this uses up quite a bit server space. That is why it will be useful depending on each moodle admins use case, I think.

As I am new to software development via git/github I was wondering whether I shall open a new pull request as I have seen the check you ran showed some line indentation errors? I was wondering whether you could give me some advice on that.
Thank you very much!

Kind regards
Simon

@mackensen
Copy link
Member

@moodleismylms you should push additional commits on your existing request and the checks will re-run. You don't need to open a new request.

@moodleismylms
Copy link
Author

@mackensen Thank you very much! I have pushed the additional commits to the main branch on moodleismylms/clampmail. Thank you very much for your support!
Kind regards
Simon

@moodleismylms
Copy link
Author

Dear @mackensen,

Apparently I have overlooked one line indentation error although one of the test runs displayed the file without errors. This should be fixed now.

Kind regards
Simon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants