Open
Conversation
Saving a draft would show the previous form values. Also a bad recipient in a saved draft would prevent using that draft. Moved code around so the $form email_form object contains the data the request should work on. Before it was a mix of accesing the request, $form or fetched database data. Moved the mailto to two <select>s logic to class email_form. Fixes needing $form to get mailto and needing mailto to create the form.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Saving a draft would show the previous form values. Also a bad recipient in a saved draft would prevent using that draft.
Moved code around so the $form email_form object contains the data the request should work on. Before it was a mix of accesing the request, $form or fetched database data.
Moved the mailto to two s logic to class email_form. Fixes needing $form to get mailto and needing mailto to create the form.