Create CAT bond module #186
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KaiOBerg
commented
Nov 7, 2025
| damages = imp_subarea_evt_flt.iloc[:, subarea] | ||
|
|
||
| # Perform optimization for each subarea | ||
| result = minimize( |
Collaborator
Author
There was a problem hiding this comment.
@spjuhel: we discussed that I should remove the initial guess in the optimization of the payout functions per subarea. However, it is a mandatory input to the minimize function. Do you have any suggestions?
Collaborator
There was a problem hiding this comment.
Isn't there a default guess that would always be a valid first guess and do not need to store ?
chahank
reviewed
Dec 2, 2025
Comment on lines
+37
to
+39
| # Monthly losses divided by principal | ||
| assert df_month["losses"].iloc[0] == [0.30, 0.50, 0.20] | ||
| assert df_month["months"].iloc[0] == [1, 2, 3] |
Member
There was a problem hiding this comment.
You can compare pandas dataframes with pandas.testing.assert_frame_equal.
chahank
reviewed
Dec 2, 2025
Comment on lines
+6
to
+12
| logging.basicConfig( | ||
| format="{asctime} - {levelname} - {message}", | ||
| style="{", | ||
| datefmt="%Y-%m-%d %H:%M", | ||
| level=logging.INFO, | ||
| ) | ||
| LOGGER = logging.getLogger(__name__) |
Member
There was a problem hiding this comment.
I am not sure where this comes frome. Can you please use the same testing environment as is used otherwise in CLIMADA?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR:
This PR fixes #
PR Author Checklist
develop)PR Reviewer Checklist