Fix missing impl headers in Spack/Precompiled installs (Fixes #1198) #1272
+11
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes Issue #1198 where
implheaders were missing when installing inCLI11_PRECOMPILEDmode (e.g., via Spack).Changes Made:
implheaders from being installed whenCLI11_PRECOMPILEDwas ON. The public headers include these files, so they must always be present.target_link_libraries(CLI11 PUBLIC Shell32)for Windows builds in precompiled mode. Without this, the build fails on Windows withLNK2019: unresolved external symbol __imp_CommandLineToArgvW.Verification
Tested locally on Windows with:
cmake .. -DCLI11_PRECOMPILED=ONcmake --build . --target installVerified that
include/CLI/impl/is now populated correctly.