-
Notifications
You must be signed in to change notification settings - Fork 5
GitHub Actions workflow for automated build and test #35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,106 @@ | ||
| name: Build and Test ldsCtrlEst | ||
|
|
||
| on: | ||
| push: | ||
| branches: | ||
| - main | ||
khansameer25 marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| pull_request: | ||
| workflow_dispatch: | ||
|
|
||
| jobs: | ||
| build: | ||
| strategy: | ||
| matrix: | ||
| os: [ubuntu-latest, macos-latest, windows-latest] | ||
|
|
||
| runs-on: ${{ matrix.os }} | ||
|
|
||
| steps: | ||
| - name: Checkout repository | ||
| uses: actions/checkout@v3 | ||
| with: | ||
| submodules: recursive | ||
|
|
||
| - name: Cache vcpkg binaries | ||
| uses: actions/cache@v3 | ||
| with: | ||
| path: ${{ runner.os == 'Windows' && 'C:\\Users\\runneradmin\\AppData\\Local\\vcpkg\\' || '~/.cache/vcpkg' }} | ||
| key: vcpkg-binary-${{ matrix.os }}-${{ hashFiles('vcpkg.json') }} | ||
| restore-keys: | | ||
| vcpkg-binary-${{ matrix.os }}- | ||
| - name: Cache vcpkg directory | ||
| uses: actions/cache@v3 | ||
| with: | ||
| path: vcpkg | ||
| key: vcpkg-${{ matrix.os }}-${{ hashFiles('vcpkg.json') }} | ||
| restore-keys: | | ||
| vcpkg-${{ matrix.os }}- | ||
| - name: Set up vcpkg for Windows | ||
| if: runner.os == 'Windows' | ||
| shell: pwsh | ||
| run: | | ||
| if (Test-Path -Path "vcpkg") { | ||
| Remove-Item -Recurse -Force "vcpkg" | ||
| } | ||
| git clone https://github.com/microsoft/vcpkg.git | ||
| cd vcpkg | ||
| .\bootstrap-vcpkg.bat | ||
| .\vcpkg integrate install | ||
| - name: Set up vcpkg for macOS/Linux | ||
| if: runner.os != 'Windows' | ||
| run: | | ||
| rm -rf vcpkg | ||
| git clone https://github.com/microsoft/vcpkg.git | ||
| cd vcpkg | ||
| ./bootstrap-vcpkg.sh | ||
| ./vcpkg integrate install | ||
|
||
| - name: Set up dependencies for macOS and Linux | ||
| if: runner.os != 'Windows' | ||
| run: | | ||
| if [ "${{ runner.os }}" == "macOS" ]; then | ||
| brew install cmake gfortran curl zip unzip gnu-tar | ||
|
||
| elif [ "${{ runner.os }}" == "Linux" ]; then | ||
| sudo apt-get update | ||
| sudo apt-get install -y cmake gfortran pkg-config build-essential | ||
| fi | ||
| - name: Set up dependencies for Windows | ||
| if: runner.os == 'Windows' | ||
| run: | | ||
| choco install cmake git | ||
| - name: Cache build directory | ||
| uses: actions/cache@v3 | ||
| with: | ||
| path: build | ||
| key: build-${{ matrix.os }}-${{ hashFiles('CMakeLists.txt') }} | ||
| restore-keys: | | ||
| build-${{ matrix.os }}- | ||
| - name: Configure and build for macOS/Linux | ||
| if: runner.os != 'Windows' | ||
| run: | | ||
| mkdir -p build && cd build | ||
| cmake .. -DCMAKE_INSTALL_PREFIX=${{github.workspace}}/install | ||
| cmake --build . --config Release --parallel | ||
| - name: Configure and build for Windows | ||
| if: runner.os == 'Windows' | ||
| shell: pwsh | ||
| run: | | ||
| if (Test-Path -Path "build") { | ||
| Remove-Item -Recurse -Force "build" | ||
| } | ||
| mkdir build | ||
| cd build | ||
| cmake .. -DCMAKE_INSTALL_PREFIX=${{github.workspace}}/install | ||
| cmake --build . --config Release --parallel | ||
| - name: Install (Windows only) | ||
| if: runner.os == 'Windows' | ||
| run: | | ||
| cd build | ||
| cmake --install . | ||
| - name: Add install directory to PATH (Windows only) | ||
| if: runner.os == 'Windows' | ||
| run: echo "${{github.workspace}}/install/bin" | Out-File -FilePath $env:GITHUB_PATH -Encoding utf8 -Append | ||
|
|
||
| - name: Run tests | ||
| run: | | ||
| cd build | ||
| ctest -C Release | ||
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice! The biggest question I have in my mind is what compilers are being used in the configure/build steps? One of the biggest headaches in getting the project to build right is that some compilers work and others don't for no apparent reason. Clang has worked most consistently across platforms, but not every version and not every machine we've tested...a mess. Assuming we will still have these problems, I think we will need to just choose a compiler, like Clang.
We may want to merge this now to get it working before adding more, but things we will want:
Then after getting the C++ build working:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The project uses default compilers: GCC on Linux, Clang on macOS, and MSVC on Windows, which are working fine so far. It's possible to specify Clang as the compiler for all platforms, but I'm unsure if it's necessary since the compiler is automatically selected based on the platform.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great---if default compilers are working let's just run with those