Activity log plugins by cheinrichs-oddball · Pull Request #6 · CMS-Enterprise/power-platform-webres

cheinrichs-oddball · 2026-02-09T21:24:38Z

EASI-0000

Power Platform scope

App / Solution:
Environment(s) impacted:
Change type (check all that apply):

Model-driven app (forms/views/commands)
Web resources (JS/HTML/CSS/images)
Dataverse schema (tables/columns/relationships/choices)
Business logic (Business Rules / Power Automate / Workflows)
Plugins (C# / registered steps)
Data migration (dataflows / M scripts / scripts)
Security (roles/teams/field security)
Integrations (connections / connectors / DLP)
Other:

Description

This PR creates three plugins.

What changed

Deployment notes

Delivery mechanism:
Solution name + version:
Manual steps required:
Secrets / connections / DLP needed:
Rollback plan:

How to test this change

Verified in environment(s)

Dev

Risk / impact

Data impact:
Backward compatibility:
Performance considerations:

PR Author Checklist

I described what changed and why.
I included clear test steps and validated in at least one environment.
I updated documentation/README if this changes how we deploy or develop.
If schema changed, I noted the Solution + components affected.
If plugin changed, I noted the message/step/stage and confirmed it runs as expected.
If data migration/dataflow changed, I tested with representative data.
No secrets, tokens, or environment-specific IDs were committed.

PR Reviewer Guidelines

Prefer pulling the branch and validating in the listed environment(s), not only reading code.
When approving, state why (tested in Dev, reviewed deployment notes, etc.).
For platform changes: verify solution/deploy steps are clear and complete.
For plugins: sanity-check registration details (Message, Stage, Filtering Attributes, Secure/Unsecure config).

…nd request

Copilot

Pull request overview

Adds a new Dataverse plugin project to enforce governance rules around Activity Log (new_activitylogs) creation and immutability for the System Intake workflow.

Changes:

Introduces three new plugin steps: sync target step to Review/Request, block no-op step changes, and block updates to Activity Logs.
Adds a new .NET Framework 4.7.1 plugin project/solution with NuGet dependencies and config.
Documents intended plugin registration details and behavior in a new README.

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 7 comments.

Show a summary per file

File	Description
apps/it-governance/plugins/ActivityLogs.Plugins/ActivityLogs.Plugins/packages.config	Adds NuGet package dependencies for the new plugin project.
apps/it-governance/plugins/ActivityLogs.Plugins/ActivityLogs.Plugins/app.config	Adds runtime binding redirect configuration for the plugin assembly.
apps/it-governance/plugins/ActivityLogs.Plugins/ActivityLogs.Plugins/README.md	Documents plugin purpose, triggers, and behavior for registration/deployment.
apps/it-governance/plugins/ActivityLogs.Plugins/ActivityLogs.Plugins/Properties/AssemblyInfo.cs	Defines assembly metadata and versioning for the new project.
apps/it-governance/plugins/ActivityLogs.Plugins/ActivityLogs.Plugins/ActivityLogs.Plugins.csproj	Creates the new .NET Framework plugin project and references required SDK assemblies.
apps/it-governance/plugins/ActivityLogs.Plugins/ActivityLogs.Plugins/ActivityLog_Update_BlockAll.cs	New plugin to block all updates to Activity Log records (immutability).
apps/it-governance/plugins/ActivityLogs.Plugins/ActivityLogs.Plugins/ActivityLog_Create_ValidateTargetStepNotCurrent.cs	New plugin to prevent creating Activity Logs that set the current step again.
apps/it-governance/plugins/ActivityLogs.Plugins/ActivityLogs.Plugins/ActivityLog_Create_SyncTargetStepToReviewAndRequest.cs	New plugin to sync the target step and clear “Ready for Review” on related records.
apps/it-governance/plugins/ActivityLogs.Plugins/ActivityLogs.Plugins.sln	Adds a Visual Studio solution for the new plugin project.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

apps/it-governance/plugins/ActivityLogs.Plugins/ActivityLogs.Plugins/README.md

.../it-governance/plugins/ActivityLogs.Plugins/ActivityLogs.Plugins/ActivityLogs.Plugins.csproj

apps/it-governance/plugins/ActivityLogs.Plugins/ActivityLogs.Plugins/app.config

Copilot · 2026-02-20T18:09:32Z

...-governance/plugins/ActivityLogs.Plugins/ActivityLogs.Plugins/ActivityLog_Update_BlockAll.cs

+        public void Execute(IServiceProvider serviceProvider)
+        {
+            var context = (IPluginExecutionContext)serviceProvider.GetService(typeof(IPluginExecutionContext));
+            if (context == null) return;
+
+            if (!string.Equals(context.PrimaryEntityName, ActivityLogEntity, StringComparison.OrdinalIgnoreCase)) return;
+            if (!string.Equals(context.MessageName, "Update", StringComparison.OrdinalIgnoreCase)) return;
+
+            // PreOperation only
+            if (context.Stage != 20) return;
+
+            // If you want to allow SYSTEM/INTEGRATION updates, you can add exceptions here later.
+            throw new InvalidPluginExecutionException(
+                "Activity Logs are immutable and cannot be updated. Create a new Activity Log entry instead."
+            );


These plugins don’t use ITracingService at all. The repo’s plugin guide recommends tracing for diagnostics, and the existing plugins use it. Consider adding basic trace statements (start/end, key IDs, and before throwing exceptions) to make production troubleshooting feasible.

Copilot · 2026-02-20T18:09:32Z

...ActivityLogs.Plugins/ActivityLogs.Plugins/ActivityLog_Create_ValidateTargetStepNotCurrent.cs

+        public void Execute(IServiceProvider serviceProvider)
+        {
+            var context = (IPluginExecutionContext)serviceProvider.GetService(typeof(IPluginExecutionContext));
+            if (context == null) return;
+
+            if (!string.Equals(context.PrimaryEntityName, ActivityLogEntity, StringComparison.OrdinalIgnoreCase)) return;
+            if (!string.Equals(context.MessageName, "Create", StringComparison.OrdinalIgnoreCase)) return;
+
+            // PreOperation only
+            if (context.Stage != 20) return;
+
+            object targetObj;
+            if (!context.InputParameters.TryGetValue("Target", out targetObj)) return;
+
+            var target = targetObj as Entity;
+            if (target == null) return;
+
+            var step = target.GetAttributeValue<OptionSetValue>(TargetStepField);
+            if (step == null) return; // if no step provided, nothing to validate
+
+            var reviewRef = target.GetAttributeValue<EntityReference>(ReviewLookupField);
+            if (reviewRef == null) return; // if no review link, nothing to validate
+
+            var serviceFactory = (IOrganizationServiceFactory)serviceProvider.GetService(typeof(IOrganizationServiceFactory));
+            var service = serviceFactory.CreateOrganizationService(context.UserId);
+
+            var review = service.Retrieve(ReviewEntity, reviewRef.Id, new ColumnSet(ReviewStepField));
+            var current = review.GetAttributeValue<OptionSetValue>(ReviewStepField);
+
+            if (current != null && current.Value == step.Value)
+            {
+                throw new InvalidPluginExecutionException(
+                    "That step is already the current step. Please choose a different target step."
+                );
+            }


This plugin performs an IOrganizationService.Retrieve but has no ITracingService logging. Adding tracing around the retrieve and the comparison (and before throwing) will make it much easier to diagnose permission issues or unexpected data in Dataverse plugin trace logs.

Copilot · 2026-02-20T18:09:33Z

...vityLogs.Plugins/ActivityLogs.Plugins/ActivityLog_Create_SyncTargetStepToReviewAndRequest.cs

+        public void Execute(IServiceProvider serviceProvider)
+        {
+            var context = (IPluginExecutionContext)serviceProvider.GetService(typeof(IPluginExecutionContext));
+            if (context == null) return;
+
+            if (!string.Equals(context.PrimaryEntityName, ActivityLogEntity, StringComparison.OrdinalIgnoreCase)) return;
+            if (!string.Equals(context.MessageName, "Create", StringComparison.OrdinalIgnoreCase)) return;
+
+            // PostOperation only
+            if (context.Stage != 40) return;
+
+            object targetObj;
+            if (!context.InputParameters.TryGetValue("Target", out targetObj)) return;
+
+            var target = targetObj as Entity;
+            if (target == null) return;
+
+            var reviewRef = target.GetAttributeValue<EntityReference>(ReviewLookupField);
+            var requestRef = target.GetAttributeValue<EntityReference>(RequestLookupField);
+
+            // Step is optional now (we still want to clear Ready for Review even if step isn't set)
+            var step = target.GetAttributeValue<OptionSetValue>(TargetStepField);
+
+            var serviceFactory = (IOrganizationServiceFactory)serviceProvider.GetService(typeof(IOrganizationServiceFactory));
+            var service = serviceFactory.CreateOrganizationService(context.UserId);
+
+            // Update Review (if present)
+            if (reviewRef != null)
+            {
+                var reviewUpdate = new Entity(ReviewEntity, reviewRef.Id);
+
+                // Sync step only if provided on the log
+                if (step != null)
+                {
+                    reviewUpdate[ReviewStepField] = new OptionSetValue(step.Value);
+                }
+
+                // Always set Ready for Review = false when an Activity Log is created
+                reviewUpdate[ReviewReadyForReviewField] = false;
+
+                service.Update(reviewUpdate);
+            }
+
+            // Update Request (if present)
+            if (requestRef != null)
+            {
+                var requestUpdate = new Entity(RequestEntity, requestRef.Id);
+
+                // Sync step only if provided on the log
+                if (step != null)
+                {
+                    requestUpdate[RequestStepField] = new OptionSetValue(step.Value);
+                }
+
+                // Always set Ready for Review = false when an Activity Log is created
+                requestUpdate[RequestReadyForReviewField] = false;
+
+                service.Update(requestUpdate);
+            }


This plugin updates two related records but has no ITracingService logging. Add tracing (IDs for Activity Log / Review / Request, whether step was present, and update outcomes) so support can troubleshoot failures (permissions, missing references) using plugin trace logs.

…ise/power-platform-webres into activity-log-plugins

WyattEmme-Oddball

Looks good to me

cheinrichs-oddball added 4 commits February 9, 2026 11:07

initial activity log plugin work

ac3c50a

changing sync plugin to update the ready to review fields on review a…

30a301e

…nd request

build change

934017d

added readme

552687c

cheinrichs-oddball requested a review from a team as a code owner February 9, 2026 21:24

cheinrichs-oddball requested review from WyattEmme-Oddball and removed request for a team February 9, 2026 21:24

cheinrichs-oddball added 2 commits February 9, 2026 13:24

Merge branch 'main' into activity-log-plugins

b5b29b4

Merge branch 'main' into activity-log-plugins

5638533

StevenWadeOddball requested a review from Copilot February 20, 2026 18:03

Copilot started reviewing on behalf of StevenWadeOddball February 20, 2026 18:04 View session

Copilot AI reviewed Feb 20, 2026

View reviewed changes

cheinrichs-oddball added 4 commits February 24, 2026 09:43

updating the snk name, updating the block all plug in

f66887a

adding trace logging to the delete and update block plugin

f3f864e

adding logging to the sync step and the valid not current step

9cd18e7

Merge branch 'activity-log-plugins' of https://github.com/CMS-Enterpr…

22a1a72

…ise/power-platform-webres into activity-log-plugins

WyattEmme-Oddball approved these changes Feb 26, 2026

View reviewed changes

Merge branch 'main' into activity-log-plugins

ba717c1

cheinrichs-oddball merged commit d2d2fee into main Feb 26, 2026
1 check passed

cheinrichs-oddball deleted the activity-log-plugins branch February 26, 2026 15:06

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Activity log plugins#6

Activity log plugins#6
cheinrichs-oddball merged 11 commits intomainfrom
activity-log-plugins

cheinrichs-oddball commented Feb 9, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI Feb 20, 2026

Uh oh!

Copilot AI Feb 20, 2026

Uh oh!

Copilot AI Feb 20, 2026

Uh oh!

WyattEmme-Oddball left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

cheinrichs-oddball commented Feb 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

EASI-0000

Power Platform scope

Description

What changed

Deployment notes

How to test this change

Verified in environment(s)

Risk / impact

PR Author Checklist

PR Reviewer Guidelines

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI Feb 20, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 20, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 20, 2026

Choose a reason for hiding this comment

Uh oh!

WyattEmme-Oddball left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

cheinrichs-oddball commented Feb 9, 2026 •

edited

Loading