Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the IT Governance model-driven app web resources to align with the updated Request/Review UX, including moving stage/progress behavior off the Business Process Flow and into the new governance step field, plus launching custom pages from command bar actions.
Changes:
- Reworked environment banner to use
Xrm.App.addGlobalNotificationbanners instead of DOM injection. - Added new command handlers to open custom pages (Edit Requests, File Upload) and a quick-create activity log flow.
- Introduced new/updated HTML web resources for request/review progress tracking and updated existing request intake web resources to use
new_admingovernanceprocessstep.
Reviewed changes
Copilot reviewed 14 out of 16 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| apps/it-governance/web-resources/js/showEnvironmentBanner.js | Switches environment indicator from injected DOM banner to global notification banner. |
| apps/it-governance/web-resources/js/openRequestEditsModal.js | Adds command handler to open the Edit Requests custom page modal and refresh the form. |
| apps/it-governance/web-resources/js/openProgressToNewStepModal.js | Adds command handler that opens an Activity Log quick-create with prefilled lookups/user/date. |
| apps/it-governance/web-resources/js/intakeReview.js | Updates section visibility logic and adds progress-tracker update logic on load. |
| apps/it-governance/web-resources/js/intakeRequestUploadDocumentsButton.js | Adds command handler to open the File Upload custom page modal and refresh the form. |
| apps/it-governance/web-resources/js/intakeRequest.js | Updates required fields and replaces legacy governance-step field usage with new_admingovernanceprocessstep. |
| apps/it-governance/web-resources/js/activityLogQuickCreate.js | Adds helper to populate activity description from the selected process step label. |
| apps/it-governance/web-resources/html/review-progress-tracker.html | New review-side progress tracker web resource (renders steps based on status). |
| apps/it-governance/web-resources/html/review-action-submit.html | New web resource to “Complete Action” by saving and resetting ActionCenter state. |
| apps/it-governance/web-resources/html/request-type.html | Updates request start logic to set new_admingovernanceprocessstep. |
| apps/it-governance/web-resources/html/request-progress-tracker.html | New request-side progress tracker web resource with legend + current step text. |
| apps/it-governance/web-resources/html/intake-upload-files.html | New upload UI web resource (currently stubbed). |
| apps/it-governance/web-resources/html/intake-request-get-started-submit.html | Updates “Get started” to set new_admingovernanceprocessstep. |
| apps/it-governance/web-resources/html/intake-request-complete-header.html | Adds a completion/read-only header web resource. |
| apps/it-governance/web-resources/html/intake-draft-submit.html | Updates draft submit behavior to set new_admingovernanceprocessstep and fire change. |
| apps/it-governance/migrations/scripts/createIntakeRequests.m | Updates migration to populate new_admingovernanceprocessstep instead of the deprecated field. |
Comments suppressed due to low confidence (2)
apps/it-governance/web-resources/js/intakeReview.js:191
updateProgressTrackerreadsnew_admingovernancetasklist, but the rest of the PR consistently usesnew_admingovernanceprocessstepfor the governance step field. As written,statusValuewill be null and the progress tracker won't update on the review form.
apps/it-governance/web-resources/js/intakeReview.js:186trackerSectionVisibleis used as a proxy for existence; if the section exists but is simply hidden, this logs "Unable to find" and exits. Consider checking for the section control separately (missing vs hidden) and only logging an error when it’s truly not present.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
apps/it-governance/web-resources/js/openProgressToNewStepModal.js
Outdated
Show resolved
Hide resolved
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
updating to handle any errors that may arise adding a notification banner Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Power Platform scope
App / Solution:
Environment(s) impacted:
Change type (check all that apply):
Description
Updating javascript and markup to match the updated UX for the Request and the Review:
What changed
Deployment notes
How to test this change
Verified in environment(s)
Risk / impact
PR Author Checklist
PR Reviewer Guidelines