Replace edit system modal with system detail page (#322)#324
Merged
danielbowne merged 5 commits intomainfrom Feb 12, 2026
Merged
Replace edit system modal with system detail page (#322)#324danielbowne merged 5 commits intomainfrom
danielbowne merged 5 commits intomainfrom
Conversation
Add routed system detail page at /systems/:fismasystemid with read-only and edit modes using card-based layout. System name column in table is now a clickable link, admin edit icon navigates to detail page. Create mode remains in existing modal. Upgrade @cmsgov/design-system to v13.
…resh - Align edit view layout to match read view (System Status card above Organization, Contacts card standalone) - Show Active/Decommissioned chip in System Identity header for both views - Resolve decommissioned_by UUID to human-readable name in both read and edit modes, not just edit mode - Fix user API response path (res.data.data.fullname) in both SystemDetailPage and EditSystemModal - Set decommissioned_by name immediately from userInfo after decommission action instead of waiting for separate API roundtrip - Add retry fetch for individual system on page refresh when system is decommissioned and not in default active-only list - Add bottom margin for spacing before footer
- Add cancellation cleanup to retry fetch effect to prevent memory leak on unmount - Remove stale closure comparison in decommissionedByName effect - Add NaN guard for invalid systemId URL parameter - Fix UTC date validation: use setUTCHours for consistent timezone comparison - Extract shared getTodayISO, truncateNotes, MAX_NOTES_LENGTH to src/utils/decommission.ts (DRY) - Replace magic number 500/100 with named constants - Standardize error handling in handleSave to match handleDecommission (add 403, 404 checks) - Fix breadcrumb underscore replacement to handle all occurrences and numeric segments
eschwein-usds
approved these changes
Feb 12, 2026
Collaborator
eschwein-usds
left a comment
eschwein-usds
left a comment
There was a problem hiding this comment.
Looks good to me, approved
danielbowne
deleted the
322-replace-edit-system-modal-with-system-detail-page
branch
22 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
EditSystemModaldialog with a full-page routed view at/systems/:fismasystemidwith card-based layout (System Identity, System Status, Organization, Contacts)decommissioned_byEditSystemModalfor "Add FISMA System" create mode only@cmsgov/design-systemfrom v10.1.2 to v13.2.0getTodayISO,truncateNotes,MAX_NOTES_LENGTH) tosrc/utils/decommission.tsTest plan
/systems/:idworks (including decommissioned systems)/systems/abc) shows "Invalid system ID" error?edit=true