BCDA-9377: Remove init from main.go for api and worker (#1200)

## 🎫 Ticket

https://jira.cms.gov/browse/BCDA-9377

## 🛠 Changes

- removed init from `bcda/main.go` and `bcdaworker/main.go`.
- added directory setup to `bcdaworker/main_test.go`

## ℹ️ Context

Part of ongoing effort to remove init to improve test suite.


<!-- If any of the following security implications apply, this PR must
not be merged without Stephen Walter's approval. Explain in this section
and add @SJWalter11 as a reviewer.
  - Adds a new software dependency or dependencies.
  - Modifies or invalidates one or more of our security controls.
  - Stores or transmits data that was not stored or transmitted before.
- Requires additional review of security implications for other reasons.
-->

## 🧪 Validation

Tests passing.

Author: laurenkrugen-navapbc

bcda/main.go

@@ -47,30 +47,25 @@ import (
 	"github.com/CMSgov/bcda-app/log"
 )
 
-func init() {
-	log.SetupLoggers()
-	client.SetLogger(log.BBAPI)
+func setupDirs() {
 
 	isEtlMode := conf.GetEnv("BCDA_ETL_MODE")
-	if isEtlMode != "true" {
-		createAPIDirs()
-	} else {
+	if isEtlMode == "true" {
+		log.API.Info("BCDA application is running in ETL mode.")
 		createETLDirs()
-	}
-
-	if isEtlMode != "true" {
+	} else {
 		log.API.Info("BCDA application is running in API mode.")
 		monitoring.GetMonitor()
-	} else {
-		log.API.Info("BCDA application is running in ETL mode.")
+		createAPIDirs()
 	}
+
 }
 
 func createAPIDirs() {
 	archive := conf.GetEnv("FHIR_ARCHIVE_DIR")
 	err := os.MkdirAll(archive, 0744)
 	if err != nil {
-		log.API.Fatal(err)
+		log.API.Fatal(errors.Wrap(err, "Could not create CCLF file archive directory"))
 	}
 }
 
@@ -83,6 +78,9 @@ func createETLDirs() {
 }
 
 func main() {
+	log.SetupLoggers()
+	client.SetLogger(log.BBAPI)
+	setupDirs()
 	app := bcdacli.GetApp()
 	err := app.Run(os.Args)
 	if err != nil {

bcdaworker/main.go

@@ -20,11 +20,6 @@ import (
 	"github.com/sirupsen/logrus"
 )
 
-func init() {
-	createWorkerDirs()
-	client.SetLogger(log.BBWorker)
-}
-
 func createWorkerDirs() {
 	staging := conf.GetEnv("FHIR_STAGING_DIR")
 	err := os.MkdirAll(staging, 0744)
@@ -98,6 +93,8 @@ func waitForSig() {
 func main() {
 	fmt.Println("Starting bcdaworker...")
 	log.SetupLoggers()
+	createWorkerDirs()
+	client.SetLogger(log.BBWorker)
 	db := database.Connect()
 	healthChecker := health.NewHealthChecker(db)
 	queue := queueing.StartRiver(db, utils.GetEnvInt("WORKER_POOL_SIZE", 4))

bcdaworker/main_test.go

@@ -10,6 +10,7 @@ import (
 )
 
 func TestClearTempDirectory(t *testing.T) {
+	createWorkerDirs()
 	tempDirPrefix := conf.GetEnv("FHIR_TEMP_DIR")
 	tempDir, err := os.MkdirTemp(tempDirPrefix, "bananas")
 	defer os.RemoveAll(tempDir)