-
Notifications
You must be signed in to change notification settings - Fork 16
BCDA-9461: Add typeFilter tests to v3 smoke tests #1282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
| " const requiredResources = [\"ExplanationOfBenefit\"];", | ||
| " const partiallyAdjudicatedResources = [\"Patient\", \"Coverage\", \"Claim\", \"ClaimResponse\"];", | ||
| " const returnedResources = respJson.output.map(r => r.type);", | ||
| "", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@colby-seyferth-nava This part is failing and Im not sure I understand why. Here is the error log from the test:
1. AssertionError Contains Required Resources
ExplanationOfBenefit is required: expected [ 'Patient', 'Coverage' ] to include 'ExplanationOfBenefit'
at assertion:2 in test-script
inside "Authenticated Endpoints / With Token / Check Filters / Get EOB export v3 job status"
I copied much of the previous end to end smoke test for v3 EOB, specifically this "name": "Get EOB export v3 job status", test, including this check.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for v3, the claim and claimresponse resources won't be returned. the explanationOfBenefit resource is a partiallyAdjudicatedResource. so the list should be Patient, Coverage, and EOB?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for v3, the claim and claimresponse resources won't be returned. the explanationOfBenefit resource is a partiallyAdjudicatedResource. so the list should be Patient, Coverage, and EOB?
Thinking about it now a better question would probably be, what/how would you want to verify a successful v3 request with typeFilter?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the best would be to do a search for PartiallyAdjudicated claims (typefilter param with _tag = partiallyAdjudicated subquery), and then check the EOB resource content to make sure each of the EOBs in the response are partially adjudicated.
Not sure the best way to check the response content using postman / newman. I think Lauren looked into that in a SPIKE before maybe?
🎫 Ticket
https://jira.cms.gov/browse/BCDA-9461
🛠 Changes
Add typeFilter smoke tests. Add missing unit tests.
ℹ️ Context
With v3 we are adding new advanced filtering options. These new smoke tests are designed to do some amount of making sure they are working as expected. The heavy duty verification is done via unit-tests.
🧪 Validation
Postman smoke test run.