Fix EOY unit-test issues #1289
Merged
Fix EOY unit-test issues #1289
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlpartridge
commented
Jan 2, 2026
| (NOW(), NOW(), 8, 'T.C9994.ACO.ZC8R68.D250909.T2135390', 'C9994', NOW(), 68, 'Completed', 1), | ||
| (NOW(), NOW(), 8, 'T.C9996.ACO.ZC8Y89.D250909.T2135490', 'C9996', NOW(), 89, 'Completed', 0), | ||
| (NOW(), NOW(), 8, 'T.C9996.ACO.ZC8R25.D250909.T2135590', 'C9996', NOW(), 25, 'Completed', 1), | ||
| (NOW(), NOW(), 8, 'T.C9996.ACO.ZC8R25.D250909.T2135590', 'C9996', NOW(), to_char(NOW(), 'yy')::int, 'Completed', 1), |
Collaborator
Author
There was a problem hiding this comment.
I dont think these changes affected the specific failing unit-tests but seemed like a good thing to update.
michaeljvaldes
approved these changes
Jan 2, 2026
Contributor
michaeljvaldes
left a comment
michaeljvaldes
left a comment
There was a problem hiding this comment.
Fwiw we have a few other references in other tests to a specific performance year (e.g. pgx_repository.test, repository.test) but I don't think those need to be updated.
laurenkrugen-navapbc
approved these changes
Jan 6, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
https://jira.cms.gov/browse/...
🛠 Changes
Removed hard-coded values from unit-tests related to EOY/runout mode.
ℹ️ Context
Some unit tests related to EOY mode were failing.
🧪 Validation
Local testing and linting.