Skip to content

BCDA-9876: enable pac data v3 ssp#1327

Merged
bhagatparwinder merged 6 commits intomainfrom
parwinder/BCDA-9876-enable-pac-data-v3-ssp
Mar 11, 2026
Merged

BCDA-9876: enable pac data v3 ssp#1327
bhagatparwinder merged 6 commits intomainfrom
parwinder/BCDA-9876-enable-pac-data-v3-ssp

Conversation

@bhagatparwinder
Copy link
Contributor

🎫 Ticket

https://jira.cms.gov/browse/BCDA-9876

🛠 Changes

New Behavior:

  • SSP model entities can access both partially adjudicated and adjudicated claims data via BCDA v3
  • KCC model entities can access only adjudicated claims data

ℹ️ Context

We don't plan to add any new model types for v1/v2 access. Like IOTA, any new models should be limited to v3. Going forward, the default will be access to both adjudicated and partially adjudicated claims data via v3.

🧪 Validation

Unit test suite

@bhagatparwinder bhagatparwinder marked this pull request as ready for review March 9, 2026 18:24
@bhagatparwinder bhagatparwinder requested a review from a team as a code owner March 9, 2026 18:24
Copy link
Collaborator

@carlpartridge carlpartridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at the long list of acceptance criteria in the ticket it feels like we should have more tests. Or are most of these existing logic and covered by existing tests?

@bhagatparwinder
Copy link
Contributor Author

Looking at the long list of acceptance criteria in the ticket it feels like we should have more tests. Or are most of these existing logic and covered by existing tests?

All of it is existing on how our endpoints behave. The difference we are making now is everyone has access to PAC and non PAC data on V3 except KCC.

Copy link
Contributor

@michaeljvaldes michaeljvaldes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a side note, the configs in the config s3 buckets will probably need to be updated as well when this PR is merged.

@bhagatparwinder
Copy link
Contributor Author

As a side note, the configs in the config s3 buckets will probably need to be updated as well when this PR is merged.

We control those through SOPS now, correct? I can make the SOPS edit in this PR.

@michaeljvaldes
Copy link
Contributor

michaeljvaldes commented Mar 10, 2026

As a side note, the configs in the config s3 buckets will probably need to be updated as well when this PR is merged.

We control those through SOPS now, correct? I can make the SOPS edit in this PR.

Unfortunately, due to obstacles in injecting environment variables in the ECS task definitions, the param store values that are files are not grabbed from SOPs/param store -- instead, they're grabbed from the environment's config bucket.
I think there are improvements we can make, possibly to link the SOPs values to the bucket files, but maybe that will be influenced a bit by where our automatic credential rotation takes us in terms of relevant tools.

@bhagatparwinder
Copy link
Contributor Author

As a side note, the configs in the config S3 buckets will probably need to be updated as well when this PR is merged.

We control those through SOPS now, correct? I can make the SOPS edit in this PR.

Unfortunately, due to obstacles in injecting environment variables in the ECS task definitions, the param store values that are files are not grabbed from SOPs/param store -- instead, they're grabbed from the environment's config bucket. I think there are improvements we can make, possibly to link the SOPs values to the bucket files, but maybe that will be influenced a bit by where our automatic credential rotation takes us in terms of relevant tools.

Got it. I will update the S3 config files post PR merger, before release.

@carlpartridge
Copy link
Collaborator

As a side note, the configs in the config S3 buckets will probably need to be updated as well when this PR is merged.

We control those through SOPS now, correct? I can make the SOPS edit in this PR.

Unfortunately, due to obstacles in injecting environment variables in the ECS task definitions, the param store values that are files are not grabbed from SOPs/param store -- instead, they're grabbed from the environment's config bucket. I think there are improvements we can make, possibly to link the SOPs values to the bucket files, but maybe that will be influenced a bit by where our automatic credential rotation takes us in terms of relevant tools.

Got it. I will update the S3 config files post PR merger, before release.

Quick reminder that you will need to update both the api and worker config files in their own respective buckets.

@bhagatparwinder bhagatparwinder merged commit 9519e51 into main Mar 11, 2026
7 checks passed
@bhagatparwinder bhagatparwinder deleted the parwinder/BCDA-9876-enable-pac-data-v3-ssp branch March 11, 2026 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants