Skip to content

BFD-4413: Switch from CLM_ to PRVDR_ columns for NPI values#2983

Open
mark-lewis-icf wants to merge 9 commits intomasterfrom
BFD-4413
Open

BFD-4413: Switch from CLM_ to PRVDR_ columns for NPI values#2983
mark-lewis-icf wants to merge 9 commits intomasterfrom
BFD-4413

Conversation

@mark-lewis-icf
Copy link
Contributor

@mark-lewis-icf mark-lewis-icf commented Jan 30, 2026

JIRA Ticket:
BFD-4413

What Does This PR Do?

  • Update model to reference new 'PRVDR_' prefix columns for NPI values instead of older 'CLM_' prefix columns
  • Update IT test data to use new columns to match model. Slight modification of data length as column definition from CLM_SRVC_PRVDR_GNRC_ID_NUM to PRVDR_SRVC_PRVDR_NPI_NUM shrank from VARCHAR(20) to VARCHAR(10)
  • Update provider ids and their references to be the NPI
  • Add verification for EOB contained resources to have unique ids per resource type

What Should Reviewers Watch For?

If you're reviewing this PR, please check for these things in particular:

  • Snapshot changes (I'm not entirely sure why the snapshot changed, but it is almost certainly my ignorance to the impact of the changes I made)

What Security Implications Does This PR Have?

Please indicate if this PR does any of the following:

  • Adds any new software dependencies

  • Modifies any security controls

  • Adds new transmission or storage of data

  • Any other changes that could possibly affect security?

  • I have considered the above security implications as it relates to this PR. (If one or more of the above apply, it cannot be merged without the ISSO or team security engineer's (@sb-benohe) approval.)

  • I have created tests to sufficiently ensure the reliability of my code, if applicable. If this is a modification to an existing piece of code, I have audited the associated tests to ensure everything works as expected.

Validation

Have you fully verified and tested these changes? Is the acceptance criteria met? Please provide reproducible testing instructions, code snippets, or screenshots as applicable.

mlewis@fedora:~/git/beneficiary-fhir-data/apps/bfd-server-ng$ mvn clean verify -DupdateSnapshot=
[INFO] Results:
[INFO]
[INFO] Tests run: 238, Failures: 0, Errors: 0, Skipped: 0
[INFO]
[WARNING] Corrupted channel by directly writing to native stream in forked JVM 1. See FAQ web page and the dump file /home/mlewis/git/beneficiary-fhir-data/apps/bfd-server-ng/target/failsafe-reports/2026-01-30T08-57-11_948-jvmRun1.dumpstream
[INFO]
[INFO] --- checkstyle:3.6.0:check (verify) @ bfd-server-ng ---
[INFO] You have 0 Checkstyle violations.
[INFO]
[INFO] --- failsafe:3.5.3:verify (default) @ bfd-server-ng ---
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 01:52 min
[INFO] Finished at: 2026-01-30T08:58:35-05:00
[INFO] ------------------------------------------------------------------------

@bfd-sast
Copy link

bfd-sast bot commented Feb 4, 2026

@mark-lewis-icf mark-lewis-icf marked this pull request as ready for review February 5, 2026 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants