BB2-3520: Undo short-term fix and adjust tests #1261
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loganbertram
approved these changes
Nov 6, 2024
Contributor
loganbertram
left a comment
loganbertram
left a comment
There was a problem hiding this comment.
Prefect! And good extra catch on the true/false positioning for the demo scopes check.
|
|
||
| # Remove demographic information scopes, if beneficiary is not sharing | ||
| if cleaned_data.get("share_demographic_scopes") == "False": | ||
| if cleaned_data.get("share_demographic_scopes") != "True": |
Contributor
There was a problem hiding this comment.
Nice catch. This is way more explicit.
jimmyfagan
deleted the
jimmyfagan/bb2-3520-remove-short-term-incident-fix
branch
loganbertram
reviewed
Nov 7, 2024
Contributor
loganbertram
left a comment
loganbertram
left a comment
There was a problem hiding this comment.
I know it's already merged, but test fixes look good!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA Ticket:
BB2-3520
What Does This PR Do?
Trueto keep demographic scopes (formerly would work forNoneas well, only relevant to unit tests)What Should Reviewers Watch For?
If you're reviewing this PR, please check for these things in particular:
== "False"to a check for!= "True"Validation
Tested this locally by trying to create a token with patient/profile scope, not selecting the demographic box and continuing. I failed to get a token as expected.
I then tested with selecting the demographic box, got a token back with patient/profile scope, and was able to use that for Patient and profile endpoints, but nothing else. All as expected. While this is out for review, and during the deployment cycle, I'll continue testing out a variety of other cases, most notably confirming that this works correctly for apps which don't display the demographic check box.
What Security Implications Does This PR Have?
Please indicate if this PR does any of the following:
security engineer's approval.
Any Migrations?
etc)