Skip to content

Conversation

@JFU-NAVA-PBC
Copy link
Contributor

@JFU-NAVA-PBC JFU-NAVA-PBC commented Nov 7, 2024

JIRA Ticket:
BB2-3471

What Does This PR Do?

Due to verifier not propagated at token exchange step, the auth with PKCE is broken (400 error).
So revert it for now to unblock r135 deploy

What Should Reviewers Watch For?

If you're reviewing this PR, please check for these things in particular:

Validation

Verify that Swagger UI authorization works - either on a local bb2 server or on a LLE

What Security Implications Does This PR Have?

Please indicate if this PR does any of the following:

  • Adds any new software dependencies
  • Modifies any security controls
  • Adds new transmission or storage of data
  • Any other changes that could possibly affect security?
  • Yes, one or more of the above security implications apply. This PR must not be merged without the ISSO or team
    security engineer's approval.

Any Migrations?

  • Yes, there are migrations
    • The migrations should be run PRIOR to the code being deployed
    • The migrations should be run AFTER the code is deployed
    • There is a more complicated migration plan (downtime,
      etc)
  • No migrations

@JFU-NAVA-PBC JFU-NAVA-PBC merged commit 64d3f45 into master Nov 7, 2024
6 checks passed
@JFU-NAVA-PBC JFU-NAVA-PBC deleted the jimfuqian/BB2-3471-swagger-ui-auth-enable-pkce-revert branch November 7, 2024 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants