jimfuqian/BB2-3471-swagger-ui-auth-w-pkce-set-verifier-4-token-exchange #1263
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA Ticket:
BB2-3471
What Does This PR Do?
A follow up PR fixing the PKCE verifier code handling in customized swagger UI code.
What Should Reviewers Watch For?
If you're reviewing this PR, please check for these things in particular:
Validation
Refer to "Validation" of PR 1260
Preferred validation - by splunk BB2 auth flow dashboard (TEST ENV): https://splunk.cloud.cms.gov/en-US/app/cms_bbapi_landing_app/bb2_authorization_flow_dashboard?form.bbEnvLabel=impl&form.bbEnv=*&form.t_local.earliest=-60m%40m&form.t_local.latest=now
PR deployed to TEST ENV.
Steps:
the screen shot shows 4 auth flow w PKCE (S256 method):
What Security Implications Does This PR Have?
Please indicate if this PR does any of the following:
security engineer's approval.
Any Migrations?
etc)