upgraded django to 4.2.16 #1264
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
noticed that there are multiple whl files for cryptography lib: only one is needed here... |
Contributor
loganbertram
left a comment
loganbertram
left a comment
There was a problem hiding this comment.
Echoing Jim's note about too many cryptography .whl files. May be worth making sure that's all in line while we're here, even if it's not to the spirit of the ticket. Everything seems to work, but I'd check those extra files in the vendor dir and remove the errant /code/ part of the path generated by pip-compile and then we should be good!
requirements/requirements.dev.txt
Outdated
| --hash=sha256:6279836d581513a26f1bf235f9acd333bc9115683f14f7e8fae46c98fc50e015 | ||
| # via | ||
| # -r requirements/requirements.in | ||
| # -r /code/requirements/requirements.in |
Contributor
There was a problem hiding this comment.
potentially ran from the wrong directory? we shouldn't be updating these. it's not a huge deal except that it will unexpectedly flip flop if people run the commands in different ways.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA Ticket:
BB2-3512
What Does This PR Do?
Upgrades Django versioning from 4.2.15 to 4.2.16
What Should Reviewers Watch For?
Any references to 4.2.15 and any possible hashes in the requirements.in file that are wrong.
Validation
Ran locally and checked major functionality like getting auth tokens.
What Security Implications Does This PR Have?
Please indicate if this PR does any of the following:
security engineer's approval.
Any Migrations?
etc)