Skip to content
Merged
Show file tree
Hide file tree
Changes from 10 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/wellknown/views/__init__.py
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
from .openid import openid_configuration, base_issuer, build_endpoint_info # NOQA
from .openid import openid_configuration, smart_configuration, base_issuer, build_endpoint_info # NOQA
from .application import ApplicationListView, ApplicationLabelView # NOQA
from .public_applications import ApplicationListView as PublicApplicationListView # NOQA
58 changes: 51 additions & 7 deletions apps/wellknown/views/openid.py
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,17 @@
import apps.logging.request_logger as bb2logging

logger = logging.getLogger(bb2logging.HHS_SERVER_LOGNAME_FMT.format(__name__))
SCOPES_SUPPORTED = ["profile", "patient/Patient.read", "patient/ExplanationOfBenefit.read", "patient/Coverage.read"]
CODE_CHALLENGE_METHODS_SUPPORTED = ["S256"]
CAPABILITIES = [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add "authorize-post"? looks like that one would also fit within the existing, supported capabilities of BB2

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll add that now.

"client-confidential-symmetric",
"sso-openid-connect",
"launch-standalone",
"permission-offline",
"permission-patient",
"permission-v1",
"authorize-post"
]


@require_GET
Expand All @@ -18,8 +29,18 @@ def openid_configuration(request):
"""
data = OrderedDict()
issuer = base_issuer(request)
v2 = request.path.endswith('openid-configuration-v2') or request.path.endswith('openidConfigV2')
data = build_endpoint_info(data, issuer=issuer, v2=v2)
data = build_endpoint_info(data, issuer=issuer)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With OIDC v2 feeding through the normal endpoint now, can you also update the swagger page to remove the -v2 from /.well-known/openid-configuration-v2? It's in openapi.yaml.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there already a follow up ticket to add the smart config to the swagger doc? If so, we can save this adjustment for that if that's preferred, if not, we should either make a ticket, or include the smart config updates to swagger docs as part of this PR.

return JsonResponse(data)


@require_GET
def smart_configuration(request):
"""
Views that returns smart_configuration.
"""
data = OrderedDict()
issuer = base_issuer(request)
data = build_smart_config_endpoint(data, issuer=issuer)
return JsonResponse(data)


Expand Down Expand Up @@ -50,7 +71,7 @@ def base_issuer(request):
return issuer


def build_endpoint_info(data=OrderedDict(), v2=False, issuer=""):
def build_endpoint_info(data=OrderedDict(), issuer=""):
"""
construct the data package
issuer should be http: or https:// prefixed url.
Expand All @@ -60,12 +81,12 @@ def build_endpoint_info(data=OrderedDict(), v2=False, issuer=""):
"""
data["issuer"] = issuer
data["authorization_endpoint"] = issuer + \
reverse('oauth2_provider:authorize' if not v2 else 'oauth2_provider_v2:authorize-v2')
reverse('oauth2_provider_v2:authorize-v2')
data["revocation_endpoint"] = issuer + reverse('oauth2_provider:revoke')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we go ahead and make this change now, I think we're done with that bug we refined yesterday:

Suggested change
data["revocation_endpoint"] = issuer + reverse('oauth2_provider:revoke')
data["revocation_endpoint"] = issuer + reverse('oauth2_provider_v2:revoke-token-v2')

Might require a test update too.

data["token_endpoint"] = issuer + \
reverse('oauth2_provider:token' if not v2 else 'oauth2_provider_v2:token-v2')
reverse('oauth2_provider_v2:token-v2')
data["userinfo_endpoint"] = issuer + \
reverse('openid_connect_userinfo' if not v2 else 'openid_connect_userinfo_v2')
reverse('openid_connect_userinfo_v2')
data["ui_locales_supported"] = ["en-US", ]
data["service_documentation"] = getattr(settings,
'DEVELOPER_DOCS_URI',
Expand All @@ -82,5 +103,28 @@ def build_endpoint_info(data=OrderedDict(), v2=False, issuer=""):

data["response_types_supported"] = ["code", "token"]
data["fhir_metadata_uri"] = issuer + \
reverse('fhir_conformance_metadata' if not v2 else 'fhir_conformance_metadata_v2')
reverse('fhir_conformance_metadata_v2')
return data


def build_smart_config_endpoint(data=OrderedDict(), issuer=""):
"""
construct the smart config endpoint response. Takes in output of build_endpoint_info since they share many fields
issuer should be http: or https:// prefixed url.

:param data:
:return:
"""

data = build_endpoint_info(data, issuer=issuer)
del (data["userinfo_endpoint"])
del (data["ui_locales_supported"])
del (data["service_documentation"])
del (data["op_tos_uri"])
del (data["fhir_metadata_uri"])

data["scopes_supported"] = SCOPES_SUPPORTED
data["code_challenge_methods_supported"] = CODE_CHALLENGE_METHODS_SUPPORTED
data["capabilities"] = CAPABILITIES

return data
3 changes: 3 additions & 0 deletions hhs_oauth_server/urls.py
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
from django.contrib import admin
from apps.accounts.views.oauth2_profile import openidconnect_userinfo
from apps.fhir.bluebutton.views.home import fhir_conformance, fhir_conformance_v2
from apps.wellknown.views.openid import smart_configuration
from hhs_oauth_server.hhs_oauth_server_context import IsAppInstalled

admin.autodiscover()
Expand All @@ -17,6 +18,7 @@
urlpatterns = [
path("health", include("apps.health.urls")),
re_path(r"^.well-known/", include("apps.wellknown.urls")),
path("v1/fhir/.wellknown/smart-configuration", smart_configuration, name="smart_configuration"),
path("forms/", include("apps.forms.urls")),
path("v1/accounts/", include("apps.accounts.urls")),
re_path(
Expand All @@ -32,6 +34,7 @@
openidconnect_userinfo,
name="openid_connect_userinfo_v2",
),
path("v2/fhir/.wellknown/smart-configuration", smart_configuration, name="smart_configuration"),
path("v2/fhir/metadata", fhir_conformance_v2, name="fhir_conformance_metadata_v2"),
path("v2/fhir/", include("apps.fhir.bluebutton.v2.urls")),
path("v2/o/", include("apps.dot_ext.v2.urls")),
Expand Down
Loading