-
Notifications
You must be signed in to change notification settings - Fork 28
adding smart on fhir configuration endpoint #1270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 6 commits
c086578
af7ce06
e585d92
2b414fb
83109af
e5ebec8
910390d
9f323b0
c389c2b
b6c5e3c
29a14c3
8850518
98862ea
84e7332
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,3 @@ | ||
| from .openid import openid_configuration, base_issuer, build_endpoint_info # NOQA | ||
| from .openid import openid_configuration, smart_configuration, base_issuer, build_endpoint_info # NOQA | ||
| from .application import ApplicationListView, ApplicationLabelView # NOQA | ||
| from .public_applications import ApplicationListView as PublicApplicationListView # NOQA |
| Original file line number | Diff line number | Diff line change | ||||||
|---|---|---|---|---|---|---|---|---|
|
|
@@ -9,6 +9,16 @@ | |||||||
| import apps.logging.request_logger as bb2logging | ||||||||
|
|
||||||||
| logger = logging.getLogger(bb2logging.HHS_SERVER_LOGNAME_FMT.format(__name__)) | ||||||||
| SCOPES_SUPPORTED = ["profile", "patient/Patient.read", "patient/ExplanationOfBenefit.read", "patient/Coverage.read"] | ||||||||
| CODE_CHALLENGE_METHODS_SUPPORTED = ["S256"] | ||||||||
| CAPABILITIES = [ | ||||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can we add "authorize-post"? looks like that one would also fit within the existing, supported capabilities of BB2
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'll add that now. |
||||||||
| "client-confidential-symmetric", | ||||||||
| "sso-openid-connect", | ||||||||
| "launch-standalone", | ||||||||
| "permission-offline", | ||||||||
| "permission-patient", | ||||||||
| "permission-v1" | ||||||||
| ] | ||||||||
|
|
||||||||
|
|
||||||||
| @require_GET | ||||||||
|
|
@@ -23,6 +33,18 @@ def openid_configuration(request): | |||||||
| return JsonResponse(data) | ||||||||
|
|
||||||||
|
|
||||||||
| @require_GET | ||||||||
| def smart_configuration(request): | ||||||||
| """ | ||||||||
| Views that returns smart_configuration. | ||||||||
| """ | ||||||||
| data = OrderedDict() | ||||||||
| issuer = base_issuer(request) | ||||||||
| v2 = request.path.endswith('smart-configuration-v2') or request.path.endswith('smartConfigV2') | ||||||||
| data = build_smart_config_endpoint(data, issuer=issuer, v2=v2) | ||||||||
| return JsonResponse(data) | ||||||||
|
|
||||||||
|
|
||||||||
| def base_issuer(request): | ||||||||
| """ | ||||||||
| define the base url for issuer | ||||||||
|
|
@@ -84,3 +106,26 @@ def build_endpoint_info(data=OrderedDict(), v2=False, issuer=""): | |||||||
| data["fhir_metadata_uri"] = issuer + \ | ||||||||
| reverse('fhir_conformance_metadata' if not v2 else 'fhir_conformance_metadata_v2') | ||||||||
| return data | ||||||||
|
|
||||||||
|
|
||||||||
| def build_smart_config_endpoint(data=OrderedDict(), v2=False, issuer=""): | ||||||||
| """ | ||||||||
| construct the smart config endpoint response. Takes in output of build_endpoint_info since they share many fields | ||||||||
| issuer should be http: or https:// prefixed url. | ||||||||
|
|
||||||||
| :param data: | ||||||||
| :return: | ||||||||
| """ | ||||||||
|
|
||||||||
| data = build_endpoint_info(data, issuer=issuer, v2=v2) | ||||||||
| del(data["userinfo_endpoint"]) | ||||||||
| del(data["ui_locales_supported"]) | ||||||||
| del(data["service_documentation"]) | ||||||||
| del(data["op_tos_uri"]) | ||||||||
| del(data["fhir_metadata_uri"]) | ||||||||
|
||||||||
| del(data["fhir_metadata_uri"]) | |
| del(data["fhir_metadata_uri"]) | |
| data["grant_types_supported"].remove("refresh_token") |
Spec says for grant_types_supported:
The options are “authorization_code” (when SMART App Launch is supported) and “client_credentials” (when SMART Backend Services is supported).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the .well-known/smart-configuration should be relative to the base path of the server, eg v2/fhir/.well-known/smart-configuration for v2, v1/fhir/.well-known/smart-configuration for v1, per environment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see what you mean. I'll have to do a bit more digging around to get it to have that pattern. Would we want to change openid-configuration to follow that pattern as well? It seems like it's the only one to have this current pattern. Swagger link for convenience: https://sandbox.bluebutton.cms.gov/docs/openapi#/v2/openIdConfig
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A good team discussion topic. imo the value of a well-known url is that you can automatically discover it. As it stands today, I'd see the same problem for the OIDC config, since openid-configuration-v2 isn't really well-known.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, I'll socialize this with the other engineers and see about making this happen