Brandon/bb2 3360 smart on fhir #1272
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to match between versions
jimmyfagan
previously approved these changes
Dec 9, 2024
Contributor
jimmyfagan
left a comment
jimmyfagan
left a comment
There was a problem hiding this comment.
Looks good to me, let's just make sure Alex signs off on this too before merging.
jimmyfagan
reviewed
Dec 12, 2024
Contributor
jimmyfagan
left a comment
jimmyfagan
left a comment
There was a problem hiding this comment.
@bwang-icf Alex pointed out that the url here is actually incorrect, it should be well-known not wellknown. Can you get that fixed as part of this PR?
jimmyfagan
dismissed
their stale review
Made new comments that should be addressed
alex-dzeda
approved these changes
Dec 12, 2024
Contributor
alex-dzeda
left a comment
alex-dzeda
left a comment
There was a problem hiding this comment.
Thank you for making the changes to the output + path.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA Ticket:
BB2-3360
What Does This PR Do?
Removing some unnecessary fields for smart config endpoint
What Should Reviewers Watch For?
Any other unnecessary fields or improper response
Validation
Ran a get request for localhost:8000/v1/fhir/.wellknown/smart-configuration and v2 in postman
What Security Implications Does This PR Have?
Please indicate if this PR does any of the following:
security engineer's approval.
Any Migrations?
etc)