Skip to content

Conversation

@stiwarisemanticbits
Copy link
Contributor

JIRA Ticket:
BB2-4303

What Does This PR Do?

This PR reverts some of changes which were done as part of PR #1423 as it was breaking selenium tests for mslsx locally

What Should Reviewers Watch For?

  1. Checkout this branch
  2. Export all aws keys from cloud tammer
  3. Execute ./docker-compose/run_selenium_tests_local.sh

If you're reviewing this PR, please check for these things in particular:

Validation

What Security Implications Does This PR Have?

Please indicate if this PR does any of the following:

  • Adds any new software dependencies
  • Modifies any security controls
  • Adds new transmission or storage of data
  • Any other changes that could possibly affect security?
  • Yes, one or more of the above security implications apply. This PR must not be merged without the ISSO or team
    security engineer's approval.

Any Migrations?

  • Yes, there are migrations
    • The migrations should be run PRIOR to the code being deployed
    • The migrations should be run AFTER the code is deployed
    • There is a more complicated migration plan (downtime,
      etc)
  • No migrations

Shivam Tiwari and others added 3 commits December 1, 2025 11:14
jadudm
jadudm previously approved these changes Dec 2, 2025
Copy link
Contributor

@jadudm jadudm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This rolls back some changes to the management command create_test_user..., which is only used in testing. The more invasive changes made previously broke the selenium tests---which wasn't known at the time, because the selenium tests were broken.

None of this is production pathway. It has been confirmed by two devs that the new stack tooling and selenium tests now run locally.

@jadudm jadudm dismissed their stale review December 2, 2025 15:36

The unit tests have a problem. Need to check everything.

Copy link
Contributor

@jadudm jadudm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good. Passes tests locally and in CI/CD.

@jadudm jadudm merged commit 21d5cac into master Dec 2, 2025
8 checks passed
@jadudm jadudm deleted the st/BB2-4303 branch December 2, 2025 16:46
JamesDemeryNava added a commit that referenced this pull request Dec 3, 2025
JamesDemeryNava added a commit that referenced this pull request Dec 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants