BB2-4303: Revert changes to fix selenium tests #1431
Merged
+75
−95
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
One more change needed for the MSLS/Selenium fixes.
stiwarisemanticbits
force-pushed
the
st/BB2-4303
branch
from
47dffd5 to
00f5e74
Compare
jadudm
previously approved these changes
Dec 2, 2025
Contributor
jadudm
left a comment
jadudm
left a comment
There was a problem hiding this comment.
This rolls back some changes to the management command create_test_user..., which is only used in testing. The more invasive changes made previously broke the selenium tests---which wasn't known at the time, because the selenium tests were broken.
None of this is production pathway. It has been confirmed by two devs that the new stack tooling and selenium tests now run locally.
jadudm
dismissed
their stale review
The unit tests have a problem. Need to check everything.
stiwarisemanticbits
force-pushed
the
st/BB2-4303
branch
from
0f00e4c to
d3b7007
Compare
jadudm
approved these changes
Dec 2, 2025
Contributor
jadudm
left a comment
jadudm
left a comment
There was a problem hiding this comment.
All good. Passes tests locally and in CI/CD.
JamesDemeryNava
added a commit
that referenced
this pull request
Dec 3, 2025
This reverts commit 21d5cac.
JamesDemeryNava
added a commit
that referenced
this pull request
Dec 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA Ticket:
BB2-4303
What Does This PR Do?
This PR reverts some of changes which were done as part of PR #1423 as it was breaking selenium tests for mslsx locally
What Should Reviewers Watch For?
./docker-compose/run_selenium_tests_local.shIf you're reviewing this PR, please check for these things in particular:
Validation
What Security Implications Does This PR Have?
Please indicate if this PR does any of the following:
security engineer's approval.
Any Migrations?
etc)