Skip to content

Conversation

@stiwarisemanticbits
Copy link
Contributor

JIRA Ticket:
BB2-3379

What Does This PR Do?

  • Add dedicated logout waffle switch so logout can be toggled independently of login. By default its enabled
  • Update both v1 and v2 account logout URLs to use the new switch

What Should Reviewers Watch For?

  • Checkout this branch, and start server
  • login into Django admin
  • Run test client
  • On the test client page, select Log out to continue
  • It should now show 404
  • Disbale logout waffle switch
  • Try again and now we should get 404

If you're reviewing this PR, please check for these things in particular:

Validation

What Security Implications Does This PR Have?

Please indicate if this PR does any of the following:

  • Adds any new software dependencies
  • Modifies any security controls
  • Adds new transmission or storage of data
  • Any other changes that could possibly affect security?
  • Yes, one or more of the above security implications apply. This PR must not be merged without the ISSO or team
    security engineer's approval.

Any Migrations?

  • Yes, there are migrations
    • The migrations should be run PRIOR to the code being deployed
    • The migrations should be run AFTER the code is deployed
    • There is a more complicated migration plan (downtime,
      etc)
  • No migrations

@JamesDemeryNava JamesDemeryNava self-assigned this Dec 3, 2025
Copy link
Contributor

@jimmyfagan jimmyfagan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! We'll want to be careful during deployment to make sure these switches are in place @stiwarisemanticbits could you pre-emptively add the logout switch with the correct values to the higher environments?

@stiwarisemanticbits stiwarisemanticbits enabled auto-merge (squash) December 3, 2025 20:45
@stiwarisemanticbits stiwarisemanticbits merged commit 374e1b1 into master Dec 3, 2025
8 checks passed
@stiwarisemanticbits stiwarisemanticbits deleted the st/BB2-3379 branch December 3, 2025 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants