BB2-4271: Refactor how migrate_fhir_id_to_v2 is run, ensure sufficient test data can be created locally #1433
+157
−131
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA Ticket:
BB2-4271
What Does This PR Do?
This ticket takes the migrate_fhir_id_to_v2 out of a migration, and puts it into a command. This ensures we won't try to update every crosswalk record in a single transaction. We also chunk the retrieval of crosswalk records, which should improve efficiency.
It also ensures we can create hundreds of thousands of crosswalk (and auth_user) records locally, so the DB we are testing against locally more closely resembles what is in prod.
@clewellyn-nava made all of the changes outside of using
objects.iterator(chunk_size=1000)instead of.all()What Should Reviewers Watch For?
If you're reviewing this PR, please check for these things in particular:
Validation
What Security Implications Does This PR Have?
Please indicate if this PR does any of the following:
security engineer's approval.
Any Migrations?
There's a modified migration, but we just remove a call to a different command.
etc)