-
Notifications
You must be signed in to change notification settings - Fork 0
[PLT-1445] Service module updates for AB2D adoption #360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
terraform/modules/service/main.tf
Outdated
| container_definitions = nonsensitive(jsonencode([ | ||
| { | ||
| name = local.service_name | ||
| name = local.container_name |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would rather assign the container and service the same name in this shared service module unless one of the teams has a very good reason to do otherwise.
terraform/modules/service/main.tf
Outdated
| logDriver = "awslogs" | ||
| options = { | ||
| awslogs-group = "/aws/ecs/fargate/${var.platform.app}-${var.platform.env}/${local.service_name}" | ||
| awslogs-group = "/aws/ecs/fargate/${var.platform.app}-${var.platform.env}/${local.awslogs_group}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as above for log groups. We should stick with the convention of naming these after the service.
9a645ee to
9e171cd
Compare
414f667 to
909079b
Compare
🎫 Ticket
https://jira.cms.gov/browse/PLT-1445
🛠 Changes
This PR contains various updates that were required in order to migrate the AB2D contracts, events and worker services and service definitions onto the service module.
ℹ️ Context
The existing AB2D contracts, events and worker services and service definitions contain some naming conventions and settings that were not supported by the current version of the service module. The changes in this PR add that support.
🧪 Validation
The following plan was generated against the AB2D test environment with the module source set to the branch of this PR:
Tofu plan output (AB2D-TEST)