[DPC-4567] Update my organizations list page#2565
Merged
lukey-luke merged 73 commits intomainfrom Apr 14, 2025
Merged
Conversation
…' into ls/feature-4567-my-ogranizations # Conflicts: # dpc-portal/app/components/core/card/organization_card_component.rb # dpc-portal/app/models/provider_organization.rb
lukey-luke
changed the title
Contributor
jdettmannnava
left a comment
jdettmannnava
left a comment
There was a problem hiding this comment.
Looks good! But I still have some questions.
Also, if you could update the lookbook preview for more than one status, that would be nice!
dpc-portal/app/components/page/organization/organization_list_component.html.erb
Outdated
Show resolved
Hide resolved
dpc-portal/app/components/core/organization_list_row/organization_list_row_component.html.erb
Outdated
Show resolved
Hide resolved
dpc-portal/spec/components/page/organization/organization_list_component_spec.rb
Outdated
Show resolved
Hide resolved
| server_error_text: We're experiencing a temporary outage due to an external system error. Please try again later. | ||
| manage_org: Manage your organization. | ||
| tos_not_signed: You must sign DPC Terms of Service. | ||
| sign_tos: Sign terms of service |
Contributor
There was a problem hiding this comment.
It looks like changing the key broke the accessibility tests, which should only fail on the fact that many pages do not meet accessibility. Please change back to tos_not_signed or update spec/system/accessibility_spec.rb
You can run the accessibility tests with make ci-portal-accessibility
I think you will need to find another way to make the "mixed ao cd" test in the accessibility tests to pass as well...
dpc-portal/app/components/page/organization/organization_list_component.html.erb
Outdated
Show resolved
Hide resolved
dpc-portal/app/components/page/organization/organization_list_component.html.erb
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
DPC-4567
🛠 Changes
ℹ️ Context
🧪 Validation
Manual testing...
AO and CD links show up in the same list
Tested "Sign terms of service", "Configuration needed", and "Configuration complete" status icons manually