Skip to content

Update webmock allows for accessiblity tests#2761

Merged
jdettmannnava merged 1 commit intomainfrom
jd/fix-accessibility
Aug 19, 2025
Merged

Update webmock allows for accessiblity tests#2761
jdettmannnava merged 1 commit intomainfrom
jd/fix-accessibility

Conversation

@jdettmannnava
Copy link
Contributor

@jdettmannnava jdettmannnava commented Aug 15, 2025

🎫 Ticket

No ticket.

🛠 Changes

spec_helper for dcp-web and dpc-portal allow calls to release-assets.githubusercontent.com instead of objects.githubusercontent.com

ℹ️ Context

Something changed, so the call for the gecko driver for accessibility tests used a different host, so webmock complained of real calls.

🧪 Validation

Accessibility tests only fail on the fact that the sites fail axe standards instead of webmock exceptions:
dpc-web: https://github.com/CMSgov/dpc-app/actions/runs/16993607204
dpc-portal: https://github.com/CMSgov/dpc-app/actions/runs/16993614683

@jdettmannnava jdettmannnava changed the title Update where objects necessary for accessiblities come from Update webmock allows for accessiblity tests Aug 15, 2025
@jdettmannnava jdettmannnava marked this pull request as ready for review August 15, 2025 15:54
@jdettmannnava jdettmannnava requested a review from a team as a code owner August 15, 2025 15:54
Copy link
Contributor

@MEspositoE14s MEspositoE14s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Easy peasy!

@jdettmannnava jdettmannnava requested a review from a team August 18, 2025 13:30
Copy link
Contributor

@ashley-weaver ashley-weaver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jdettmannnava jdettmannnava merged commit 473f986 into main Aug 19, 2025
18 of 21 checks passed
@jdettmannnava jdettmannnava deleted the jd/fix-accessibility branch August 19, 2025 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants