-
Notifications
You must be signed in to change notification settings - Fork 18
DPC-4966 remove redis #2831
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
DPC-4966 remove redis #2831
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashley-weaver
approved these changes
Nov 14, 2025
Contributor
ashley-weaver
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
MEspositoE14s
approved these changes
Nov 14, 2025
Contributor
MEspositoE14s
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
https://jira.cms.gov/browse/DPC-4966
🛠 Changes
ℹ️ Context
With the removal of sidekiq we no longer need redis. Web and Admin were using Redis to cache email address to throttle potential spam; this caching was moved to the default Rails cache (FileStore). As we only have one instance of each running in the sandbox, localized caching should not affect behavior.
🧪 Validation
Local testing with logs showed that email throttling still works.
Quick Deployment works: https://github.com/CMSgov/dpc-app/actions/runs/19374573001
(ci did the testing)